From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Remove utils/acl.h from catalog/objectaddress.h
Date: Sun, 08 Mar 2020 14:28:57 -0400
Message-ID: <26906.1583692137@sss.pgh.pa.us> (raw)
In-Reply-To: <7601e258-26b2-8481-36d0-dc9dca6f28f1@2ndquadrant.com>
References: <7601e258-26b2-8481-36d0-dc9dca6f28f1@2ndquadrant.com>
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> I noticed that catalog/objectaddress.h includes utils/acl.h for no
> apparent reason. It turns out this used to be needed but not anymore.
> So removed it and cleaned up the fallout. Patch attached.
Seems reasonable. One thing I noticed is that if you are including
nodes/parsenodes.h explicitly in objectaddress.h, there seems little
point in the #include "nodes/pg_list.h" right beside it.
Sometime we really ought to make an effort to make our header inclusions
less of a mass of spaghetti. But this patch needn't take on that load.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com
Subject: Re: Remove utils/acl.h from catalog/objectaddress.h
In-Reply-To: <26906.1583692137@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox