pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: ALTER TABLE on system catalogs
Date: Mon, 20 Aug 2018 12:43:20 +0200
Message-ID: <26b0015a-03c5-efcd-9b47-c5a0e0ed0832@2ndquadrant.com> (raw)
In-Reply-To: <20180820023749.GD7403@paquier.xyz>
References: <e49f825b-fb25-0bc8-8afc-d5ad895c7975@2ndquadrant.com>
	<20180627203733.bfpibxdleimvwdg2@alap3.anarazel.de>
	<20180627230838.GI2667@paquier.xyz>
	<9fb22a98-fd64-1426-a4f4-b927ce1a9a5e@2ndquadrant.com>
	<920b7cde-6926-4ad3-936b-7637f0a8188f@2ndquadrant.com>
	<20180820023749.GD7403@paquier.xyz>

On 20/08/2018 04:37, Michael Paquier wrote:
> For 0002, indeed the patch is still
> seems relevant.  The comment block at the beginning of
> create_toast_table should be updated.  Some tests would also be nice to
> have.

Tests would require enabling allow_system_table_mods, which is
PGC_POSTMASTER, so we couldn't do it inside the normal regression test
suite.  I'm not sure setting up a whole new test suite for this is worth it.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

view thread (25+ messages)  latest in thread

Message-ID: <26b0015a-03c5-efcd-9b47-c5a0e0ed0832@2ndquadrant.com>
Permalink:  ../26b0015a-03c5-efcd-9b47-c5a0e0ed0832@2ndquadrant.com/
Also on:    postgresql.org/message-id/26b0015a-03c5-efcd-9b47-c5a0e0ed0832@2ndquadrant.com

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, michael@paquier.xyz, andres@anarazel.de
  Subject: Re: ALTER TABLE on system catalogs
  In-Reply-To: <26b0015a-03c5-efcd-9b47-c5a0e0ed0832@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox