pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Gurjeet Singh <gurjeet@singh.im>
Cc: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: PGSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: /proc/self/oom_adj is deprecated in newer Linux kernels
Date: Mon, 16 Jun 2014 20:42:48 -0400
Message-ID: <27626.1402965768@sss.pgh.pa.us> (raw)
In-Reply-To: <CABwTF4WKYb5XfT1QdeocjpEPeyWbS7ANYoH3LOb7hCodNEhAWQ@mail.gmail.com>
References: <29121.1316185073@sss.pgh.pa.us>
	<1316355543.12186.9.camel@vanquo.pezone.net>
	<15953.1316362868@sss.pgh.pa.us>
	<1316420754.14001.3.camel@fsopti579.F-Secure.com>
	<16241.1316441883@sss.pgh.pa.us>
	<CABwTF4XDdYiBQXqj=CKrFXN7x2NiBbVnpHSJG6AVnMBLnLBmLA@mail.gmail.com>
	<20140610143202.GI8406@alap3.anarazel.de>
	<30402.1402412692@sss.pgh.pa.us>
	<20140610150933.GK8406@alap3.anarazel.de>
	<30709.1402413628@sss.pgh.pa.us>
	<20140610153347.GM8406@alap3.anarazel.de>
	<31348.1402415537@sss.pgh.pa.us>
	<CABwTF4WmOg_YjJs9igdeUkRcBmPeGAtX_uCxoYPHueczuK+Zbw@mail.gmail.com>
	<31652.1402416356@sss.pgh.pa.us>
	<CABwTF4WKYb5XfT1QdeocjpEPeyWbS7ANYoH3LOb7hCodNEhAWQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Gurjeet Singh <gurjeet@singh.im> writes:
> Please find attached the patch. It includes the doc changes as well.

What exactly is the point of the static state you added here?  There
is no situation where that could possibly be useful, because this
code is executed at most once per process, and not at all in the
postmaster.  AFAICS, that's just complication (and permanent waste
of a kilobyte of static data space) for no return.

Also, this seems to try to write the file whether or not the environment
variable was set, which wasn't the plan.

I also don't really see the point of parsing the value variable into an
int.  Why not just spit it out as the original string?  It's not ours to
legislate whether the kernel will take a value that's not an integer.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (66+ messages)  latest in thread

Message-ID: <27626.1402965768@sss.pgh.pa.us>
Permalink:  ../27626.1402965768@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/27626.1402965768@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, gurjeet@singh.im, andres@anarazel.de, peter_e@gmx.net
  Subject: Re: /proc/self/oom_adj is deprecated in newer Linux kernels
  In-Reply-To: <27626.1402965768@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox