pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: David Steele <david@pgbackrest.org>
To: Benoit Lobréau <benoit.lobreau@dalibo.com>
To: Andrey M. Borodin <x4mmm@yandex-team.ru>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Fix logging for invalid recovery timeline
Date: Wed, 19 Feb 2025 17:35:18 +0000 (UTC)
Message-ID: <2765f538-b06f-4e57-bcb2-9ca1dc6f487d@pgbackrest.org> (raw)
In-Reply-To: <4ed10bc8-5513-4d8e-8643-8abcaa08336d@dalibo.com>
References: <c3d617d4-1696-4aa7-8a4d-5a7d19cc5618@pgbackrest.org>
	<C748635E-B2FF-4813-B035-AE670832B9FD@yandex-team.ru>
	<d0b27c08-d30f-4a1d-990d-5c90ca0a650a@pgbackrest.org>
	<4ed10bc8-5513-4d8e-8643-8abcaa08336d@dalibo.com>

On 2/19/25 03:51, Benoit Lobréau wrote:
> 
> I think the changes make sense. Would it be helpful to add the origin of 
> the checkpoint record we are referring to ? (i.e. control file or backup 
> label).
> 
> For example:
> 
> * Latest checkpoint in the control file is at %X/%X on timeline %u,
> * Checkpoint location in the backup_label file is at %X/%X on timeline %u,

I like this idea but I would prefer to get the patch committed as-is 
first. The reason is that I'm hoping to see this batch-patched (since it 
is a bug) and that is less likely if the message wording is change.

Your idea would be perfect going forward, though.

Regards,
-David





view thread (16+ messages)  latest in thread

Message-ID: <2765f538-b06f-4e57-bcb2-9ca1dc6f487d@pgbackrest.org>
Permalink:  ../2765f538-b06f-4e57-bcb2-9ca1dc6f487d@pgbackrest.org/
Also on:    postgresql.org/message-id/2765f538-b06f-4e57-bcb2-9ca1dc6f487d@pgbackrest.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: david@pgbackrest.org, benoit.lobreau@dalibo.com, x4mmm@yandex-team.ru
  Subject: Re: Fix logging for invalid recovery timeline
  In-Reply-To: <2765f538-b06f-4e57-bcb2-9ca1dc6f487d@pgbackrest.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox