From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Noah Misch <noah@leadboat.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Jelte Fennema <postgres@jeltef.nl>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Jesse Zhang <sbjesse@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: run pgindent on a regular basis / scripted manner
Date: Mon, 06 Feb 2023 16:36:07 -0500
Message-ID: <2828975.1675719367@sss.pgh.pa.us> (raw)
In-Reply-To: <20230206212157.axnz62oagvycvcjm@awork3.anarazel.de>
References: <20230123173136.knn77pbuakhvjfgk@awork3.anarazel.de>
<Y874Fh0q4mkk1s22@momjian.us>
<CAGECzQTqoGHrePM_pwmhaM+J1XOygYjzFod4sf=PAt7J4A19Mw@mail.gmail.com>
<2238493.1674572097@sss.pgh.pa.us>
<Y9ArogF7c+UgPgq9@momjian.us>
<20230129010603.GA1677550@rfd.leadboat.com>
<Y9groc0Nyy7SOROy@momjian.us>
<20230202062838.GA1832088@rfd.leadboat.com>
<1477791.1675320029@sss.pgh.pa.us>
<764a8f96-58c3-361d-428f-7ef827d62023@enterprisedb.com>
<20230206212157.axnz62oagvycvcjm@awork3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On 2023-02-06 18:17:02 +0100, Peter Eisentraut wrote:
>> First, as a matter of principle, it would introduce another level of
>> gatekeeping power. Right now, the committers are as a group in charge of
>> what gets into the tree. Adding commit hooks that are installed
>> somewhere(?) by someone(?) and can only be seen by some(?) would upset that.
>> If we were using something like github or gitlab (not suggesting that, but
>> for illustration), then you could put this kind of thing under .github/ or
>> similar and then it would be under the same control as the source code
>> itself.
> Well, we did talk about adding a pre-commit hook to the repository, with
> instructions for how to enable it. And I don't see a problem with adding the
> pre-receive we're discussing here to src/tools/something.
Yeah. I don't think we are seriously considering putting any restrictions
in place on gitmaster --- the idea is to offer better tools to committers
to let them check/fix the indentation of what they are working on. If
somebody wants to run that as a local pre-commit hook, that's their choice.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, peter.eisentraut@enterprisedb.com, noah@leadboat.com, bruce@momjian.us, postgres@jeltef.nl, pg@bowt.ie, magnus@hagander.net, alvherre@2ndquadrant.com, sfrost@snowman.net, sbjesse@gmail.com
Subject: Re: run pgindent on a regular basis / scripted manner
In-Reply-To: <2828975.1675719367@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox