pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: remove ancient pre-dlopen dynloader code
Date: Fri, 31 Aug 2018 11:05:57 -0400
Message-ID: <28859.1535727957@sss.pgh.pa.us> (raw)
In-Reply-To: <e11a49cb-570a-60b7-707d-7084c8de0e61@2ndquadrant.com>
References: <3e3c7552-978b-486a-1a4a-326ee31d0545@2ndquadrant.com>
	<20180809123059.32g25qn7dgd33iyq@alap3.anarazel.de>
	<26726.1533823423@sss.pgh.pa.us>
	<20180816083107.2f5gxbvlsgvnuit4@alap3.anarazel.de>
	<8022.1534425734@sss.pgh.pa.us>
	<20180816135928.qer5o7uxyaeolzet@alap3.anarazel.de>
	<10102.1534428424@sss.pgh.pa.us>
	<20180816141005.nkw5nwkmoip57ui6@alap3.anarazel.de>
	<e11a49cb-570a-60b7-707d-7084c8de0e61@2ndquadrant.com>

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> How about this: We only have two nonstandard dlopen() implementations
> left: Windows and (old) HP-UX.  We move those into src/port/dlopen.c and
> treat it like a regular libpgport member.  That gets rid of all those
> duplicative empty per-platform files.

+1.  I eyeballed the patch quickly and it looks sane, but I didn't
try to test it.  Being a lazy person, I don't want to test it manually,
but I'll be happy to queue up a gaur run as soon as you push it
(and if by some chance that shows a problem, I'll fix it).

			regards, tom lane




view thread (16+ messages)  latest in thread

Message-ID: <28859.1535727957@sss.pgh.pa.us>
Permalink:  ../28859.1535727957@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/28859.1535727957@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, andres@anarazel.de
  Subject: Re: remove ancient pre-dlopen dynloader code
  In-Reply-To: <28859.1535727957@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox