From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Raúl Marín Rodríguez <rmrodriguez@carto.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] pgbench tap tests fail if the path contains a perl special character
Date: Fri, 18 Jan 2019 15:02:46 -0500
Message-ID: <29026.1547841766@sss.pgh.pa.us> (raw)
In-Reply-To: <201901181927.sbv5o72uu4cc@alvherre.pgsql>
References: <201901181927.sbv5o72uu4cc@alvherre.pgsql>
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>>> This does not look right to me: glob has a different set of special
>>> characters than regexes, no?
> Perhaps you can do
> @quoted = map { quotemeta($_) } @logs;
Actually, playing with it here, it seems that quotemeta() quotes
anything that's a special character for either purpose (in fact,
it looks like it quotes anything that's not alphanumeric).
So the patch as given should work.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, rmrodriguez@carto.com
Subject: Re: [PATCH] pgbench tap tests fail if the path contains a perl special character
In-Reply-To: <29026.1547841766@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox