pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling)
Date: Tue, 17 Jan 2017 12:52:20 -0500
Message-ID: <29207.1484675540@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoboiMYk1jTL-=2a0iukktCoDnKHMhrQ9za8JrMvkFdYUw@mail.gmail.com>
References: <20160912173815.dlew2xsblcso33sw@alap3.anarazel.de>
	<17324.1473716167@sss.pgh.pa.us>
	<20160912220705.b77smzorutebnbee@alap3.anarazel.de>
	<19682.1473719703@sss.pgh.pa.us>
	<20160912231144.f3nseocp274iq7wg@alap3.anarazel.de>
	<23413.1473723322@sss.pgh.pa.us>
	<20160912234630.caueobrrbg5vse5y@alap3.anarazel.de>
	<557.1473895705@sss.pgh.pa.us>
	<20161031160639.nyxoktszi5psl2cc@alap3.anarazel.de>
	<20170116032952.z2re55hcfhzbkmrm@alap3.anarazel.de>
	<20170116083316.2izqrxbvmyalazac@alap3.anarazel.de>
	<21924.1484593998@sss.pgh.pa.us>
	<CA+TgmoboiMYk1jTL-=2a0iukktCoDnKHMhrQ9za8JrMvkFdYUw@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Jan 16, 2017 at 2:13 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> "Srf" is ugly as can be, and unintelligible.  SetResult might be OK.

> The operation we're performing here, IIUC, is projection.  SetResult
> lacks a verb, although Set could be confused with one; someone might
> think this is the node that sets a result, whatever that means.
> Anyway, I suggest working Project in there somehow.  If Project by
> itself seems like it's too generic, perhaps ProjectSet or
> ProjectSetResult would be suitable.

Andres' patch is already using "SetProjectionPath" for the path struct
type.  Maybe make that "ProjectSetPath", giving rise to a "ProjectSet"
plan node?

I'm happy to do a global-search-and-replace while I'm reviewing the
patch, but let's decide on names PDQ.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (110+ messages)  latest in thread

Message-ID: <29207.1484675540@sss.pgh.pa.us>
Permalink:  ../29207.1484675540@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/29207.1484675540@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, andres@anarazel.de
  Subject: Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling)
  In-Reply-To: <29207.1484675540@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox