pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Making C function declaration parameter names consistent with corresponding definition names
Date: Sat, 17 Sep 2022 14:26:25 -0400
Message-ID: <29327.1663439185@sss.pgh.pa.us> (raw)
In-Reply-To: <CAH2-WzkxuxfhgbToOrx_tz+KObzYQP+2MN6dBQoD-jy8vC8_0Q@mail.gmail.com>
References: <CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com>
	<3913123.1663370391@sss.pgh.pa.us>
	<CAH2-WzmxBXZAE6eyAm1XyPp6X7epCwih5qBupTxQOc6Hqp48fQ@mail.gmail.com>
	<3922750.1663372191@sss.pgh.pa.us>
	<CAH2-Wzk2etJjj8rhKn9MG9hQ2B+5tWuZneCkGyusqraGQaaeBA@mail.gmail.com>
	<3955318.1663377656@sss.pgh.pa.us>
	<CAH2-WzmykEKQzrcxHZNAuUs7GE2pL+jMa=vMZAzoXhrjG6L6XQ@mail.gmail.com>
	<CAH2-WzkxuxfhgbToOrx_tz+KObzYQP+2MN6dBQoD-jy8vC8_0Q@mail.gmail.com>

Peter Geoghegan <pg@bowt.ie> writes:
> Several files from src/timezone and from src/backend/regex make use of
> unnamed parameters in function declarations. It wouldn't be difficult
> to fix everything and call it a day, but I wonder if there are any
> special considerations here. I don't think that Henry Spencer's regex
> code is considered vendored code these days (if it ever was), so that
> seems clear cut. I'm less sure about the timezone code.

Yeah, bringing the regex code into line with our standards is fine.
I don't really see a reason not to do it with the timezone code
either, as long as there aren't too many changes there.  We are
carrying a pretty large number of diffs from upstream already.

(Which reminds me that I need to do another update pass on that
code soon.  Not right now, though.)

			regards, tom lane





view thread (27+ messages)  latest in thread

Message-ID: <29327.1663439185@sss.pgh.pa.us>
Permalink:  ../29327.1663439185@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/29327.1663439185@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pg@bowt.ie, pgsql-hackers@lists.postgresql.org
  Subject: Re: Making C function declaration parameter names consistent with corresponding definition names
  In-Reply-To: <29327.1663439185@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox