pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Ashutosh Sharma <ashu.coek88@gmail.com>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Dave Page <dpage@pgadmin.org>
Cc: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: pl/perl extension fails on Windows
Date: Thu, 27 Jul 2017 16:33:32 -0400
Message-ID: <29418.1501187612@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+Tgmobkc5u1hGP48XvtgLFuK8CFYpBVMDGQFqtGpV2Xetz1cQ@mail.gmail.com>
References: <CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=rcA@mail.gmail.com>
	<4569.1499873707@sss.pgh.pa.us>
	<CA+OCxox=h5xftcnyk1AfA_QKSQSruD=Er0qweZakiCEg3U4rcg@mail.gmail.com>
	<6063dd4c-cd1e-d9d8-fa0d-3bddb1403c66@2ndQuadrant.com>
	<CAE9k0PkWhEeNS4b5bnoQLeZsnqe4zqkr=4GhN2Ybt1nSsBFk2g@mail.gmail.com>
	<184f1fb9-dfa2-ef2d-024b-7933486e018a@2ndQuadrant.com>
	<16093.1499956602@sss.pgh.pa.us>
	<bb3d3eb6-e310-471c-1d8c-d239ecaf52ad@2ndQuadrant.com>
	<7480.1499965218@sss.pgh.pa.us>
	<CAE9k0Pnvw63MLR=dT1NYdL_t_ptyFqW1ueJwixcsmobadpFWng@mail.gmail.com>
	<30585.1500480763@sss.pgh.pa.us>
	<CAE9k0PnQzRRYEGy1j51D6F-fZeHWoy2GAghewBORWNjwg44y5g@mail.gmail.com>
	<32468.1500498091@sss.pgh.pa.us>
	<CA+TgmoY=3ApjWL0Y0Z_qdDVuK_koP9H_euHMewG06ukWxBW2Cw@mail.gmail.com>
	<CA+TgmoYqTcE8Q-GsfHJvndQPit7iqf63YY=BtGhZM7+qGjfy+g@mail.gmail.com>
	<20729.1501039314@sss.pgh.pa.us>
	<CAE9k0Pkya48GWPF7CViFu7zrJeQGm7Jzs0Wvkx2O1yAsi7EPgQ@mail.gmail.com>
	<CAE9k0PnobqEa0YH48yYGTkQKL0wFh6-BsQEn-_XnBtcbLgRfKQ@mail.gmail.! com>
	<22864.1501165302@sss.pgh.pa.us>
	<CA+Tgmobkc5u1hGP48XvtgLFuK8CFYpBVMDGQFqtGpV2Xetz1cQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Robert Haas <robertmhaas@gmail.com> writes:
> How about we fix it like this?

That seems pretty invasive; I'm not excited about breaking a lot of
unrelated code (particularly third-party extensions) for plperl's benefit.
Even if we wanted to do that in HEAD, it seems like a nonstarter for
released branches.

An even bigger issue is that if Perl feels free to redefine sigsetjmp,
what other libc calls might they decide to horn in on?

So I was trying to figure a way to not include XSUB.h except in a very
limited part of plperl, like ideally just the .xs files.  It's looking
like that would take nontrivial refactoring though :-(.  Another problem
is that this critical bit of the library API is in XSUB.h:

#if defined(PERL_IMPLICIT_CONTEXT) && !defined(PERL_NO_GET_CONTEXT) && !defined(PERL_CORE)
#  undef aTHX
#  undef aTHX_
#  define aTHX		PERL_GET_THX
#  define aTHX_		aTHX,
#endif

As best I can tell, that's absolute brain death on the part of the Perl
crew; it means you can't write working calling code at all without
including XSUB.h, or at least copying-and-pasting this bit out of it.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (94+ messages)  latest in thread

Message-ID: <29418.1501187612@sss.pgh.pa.us>
Permalink:  ../29418.1501187612@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/29418.1501187612@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, ashu.coek88@gmail.com, andrew.dunstan@2ndquadrant.com, dpage@pgadmin.org, sandeep.thakkar@enterprisedb.com
  Subject: Re: pl/perl extension fails on Windows
  In-Reply-To: <29418.1501187612@sss.pgh.pa.us>
  References: <CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=rcA@mail.gmail.com> <6063dd4c-cd1e-d9d8-fa0d-3bddb1403c66@2ndQuadrant.com> <CAE9k0PkWhEeNS4b5bnoQLeZsnqe4zqkr=4GhN2Ybt1nSsBFk2g@mail.gmail.com> <184f1fb9-dfa2-ef2d-024b-7933486e018a@2ndQuadrant.com> <16093.1499956602@sss.pgh.pa.us> <bb3d3eb6-e310-471c-1d8c-d239ecaf52ad@2ndQuadrant.com> <7480.1499965218@sss.pgh.pa.us> <CAE9k0Pnvw63MLR=dT1NYdL_t_ptyFqW1ueJwixcsmobadpFWng@mail.gmail.com> <30585.1500480763@sss.pgh.pa.us> <CAE9k0PnQzRRYEGy1j51D6F-fZeHWoy2GAghewBORWNjwg44y5g@mail.gmail.com> <32468.1500498091@sss.pgh.pa.us> <CA+TgmoY=3ApjWL0Y0Z_qdDVuK_koP9H_euHMewG06ukWxBW2Cw@mail.gmail.com> <CA+TgmoYqTcE8Q-GsfHJvndQPit7iqf63YY=BtGhZM7+qGjfy+g@mail.gmail.com> <20729.1501039314@sss.pgh.pa.us> <CAE9k0Pkya48GWPF7CViFu7zrJeQGm7Jzs0Wvkx2O1yAsi7EPgQ@mail.gmail.com> <22864.1501165302@sss.pgh.pa.us> <CA+Tgmobkc5u1hGP48XvtgLFuK8CFYpBVMDGQFqtGpV2Xetz1cQ@mail.gmail.com> <29418.1501187612@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox