public inbox for [email protected]
help / color / mirror / Atom feedFrom: Daniel Gustafsson <[email protected]>
To: Nazir Bilal Yavuz <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: meson: Non-feature feature options
Date: Thu, 9 Mar 2023 15:15:49 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAN55FZ3GLXkWHpVwwU=OpLxid2vjSSsvrpW8MRPMWzC3JRvD5w@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<CAN55FZ2Bz5P_sd2+1KBwWa9v4vDByM2UX7rKfzQs7yj6buojsg@mail.gmail.com>
<[email protected]>
<CAN55FZ3JkWJRgBOvaB0VDYg1F+v3QMg4vwVae1gpQ+mnsYc-3g@mail.gmail.com>
<[email protected]>
<CAN55FZ1UFQfKifUV=oAf+WseCxD0Kq3g_AvWEEety9VneMvzvw@mail.gmail.com>
<[email protected]>
<CAN55FZ1=-jb38PujfcMWjAH8vDTYoxrgvz_oha_p+q0quMtzCw@mail.gmail.com>
<[email protected]>
<[email protected]>
<CAN55FZ3GLXkWHpVwwU=OpLxid2vjSSsvrpW8MRPMWzC3JRvD5w@mail.gmail.com>
> On 9 Mar 2023, at 15:12, Nazir Bilal Yavuz <[email protected]> wrote:
>
> Hi,
>
> On Thu, 9 Mar 2023 at 16:54, Daniel Gustafsson <[email protected]> wrote:
>>
>>> On 9 Mar 2023, at 14:45, Peter Eisentraut <[email protected]> wrote:
>>
>>> How about we just hardcode "openssl" here instead? We could build that array dynamically, of course, but maybe we leave that until we actually have a need?
>>
>> At least for 16 keeping it hardcoded is an entirely safe bet so +1 for leaving
>> additional complexity for when needed.
>
> We already have the 'ssl_library' variable. Can't we use that instead
> of hardcoding 'openssl'? e.g:
>
> summary(
> {
> 'ssl': ssl.found() ? [ssl, '(@0@)'.format(ssl_library)] : ssl,
> },
> section: 'External libraries',
> list_sep: ', ',
> )
>
> And it will output:
> ssl : YES 3.0.8, (openssl)
>
> I don't think that using 'ssl_library' will increase the complexity.
That seems like a good idea.
--
Daniel Gustafsson
view thread (22+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: meson: Non-feature feature options
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox