pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alexander Lakhin <exclusion@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
To: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Cc: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: vignesh C <vignesh21@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bind
Date: Tue, 17 Sep 2024 18:00:00 +0300
Message-ID: <2e5b89af-a351-ff0a-000c-037ac28314ab@gmail.com> (raw)
In-Reply-To: <Zsbp4sPKF_NlGsH4@paquier.xyz>
References: <CALDaNm2i=xY85Jhg5Pr+7-yTt_Ar3tQebrDGRvxB4j2VqWEOZw@mail.gmail.com>
	<6cece376-07c6-4075-87b6-937156814202@enterprisedb.com>
	<ZpnODDZT-aosIUAE@paquier.xyz>
	<ee4e5b89-ec77-4b95-ae87-d33e31e8a5e7@enterprisedb.com>
	<ZqCLRa5OxPqzqWh6@paquier.xyz>
	<4e9ef9f3-0227-45cf-a2a6-5b43ce1bd2a1@eisentraut.org>
	<ZqG2HAgns3nv3tFY@paquier.xyz>
	<CAO6_XqpG3a0cCHkhc1HGPGrkNqCttbM3UCqnSTEn+zFCau6Baw@mail.gmail.com>
	<CAGECzQSdE2M_xz0stVU0_dF-cPqA+BW-M2RCDn4HR18hLCOGPQ@mail.gmail.com>
	<CAO6_XqpwkP4THB3bGV-rgjNsTxQnU1h52Mi1dZGS7ewpzNj76g@mail.gmail.com>
	<Zsbp4sPKF_NlGsH4@paquier.xyz>

Hello Michael and Anthonin,

22.08.2024 10:33, Michael Paquier wrote:
> Looks OK to me.  I have spent more time double-checking the whole, and
> it looks like we're there, so applied.  Now let's play with it in more
> regression tests.  Note that the refactoring patch has been merged
> with the original one in a single commit.

Please look at an assertion failure, caused by \bind_named:
regression=# SELECT $1 \parse s
\bind_named s

regression=# \bind_named
\bind_named: missing required argument
regression=# 1 \g
psql: common.c:1501: ExecQueryAndProcessResults: Assertion `pset.stmtName != ((void *)0)' failed.

Best regards,
Alexander





view thread (44+ messages)  latest in thread

Message-ID: <2e5b89af-a351-ff0a-000c-037ac28314ab@gmail.com>
Permalink:  ../2e5b89af-a351-ff0a-000c-037ac28314ab@gmail.com/
Also on:    postgresql.org/message-id/2e5b89af-a351-ff0a-000c-037ac28314ab@gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: exclusion@gmail.com, michael@paquier.xyz, anthonin.bonnefoy@datadoghq.com, postgres@jeltef.nl, peter@eisentraut.org, tomas.vondra@enterprisedb.com, vignesh21@gmail.com
  Subject: Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bind
  In-Reply-To: <2e5b89af-a351-ff0a-000c-037ac28314ab@gmail.com>
  References: <CALDaNm2i=xY85Jhg5Pr+7-yTt_Ar3tQebrDGRvxB4j2VqWEOZw@mail.gmail.com> <6cece376-07c6-4075-87b6-937156814202@enterprisedb.com> <ZpnODDZT-aosIUAE@paquier.xyz> <ee4e5b89-ec77-4b95-ae87-d33e31e8a5e7@enterprisedb.com> <ZqCLRa5OxPqzqWh6@paquier.xyz> <4e9ef9f3-0227-45cf-a2a6-5b43ce1bd2a1@eisentraut.org> <ZqG2HAgns3nv3tFY@paquier.xyz> <CAO6_XqpG3a0cCHkhc1HGPGrkNqCttbM3UCqnSTEn+zFCau6Baw@mail.gmail.com> <CAGECzQSdE2M_xz0stVU0_dF-cPqA+BW-M2RCDn4HR18hLCOGPQ@mail.gmail.com> <CAO6_XqpwkP4THB3bGV-rgjNsTxQnU1h52Mi1dZGS7ewpzNj76g@mail.gmail.com> <Zsbp4sPKF_NlGsH4@paquier.xyz> <2e5b89af-a351-ff0a-000c-037ac28314ab@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox