pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling)
Date: Tue, 17 Jan 2017 13:18:02 -0500
Message-ID: <30268.1484677082@sss.pgh.pa.us> (raw)
In-Reply-To: <20170117180324.dqgz23xaf6wtazb4@alap3.anarazel.de>
References: <20160912231144.f3nseocp274iq7wg@alap3.anarazel.de>
	<23413.1473723322@sss.pgh.pa.us>
	<20160912234630.caueobrrbg5vse5y@alap3.anarazel.de>
	<557.1473895705@sss.pgh.pa.us>
	<20161031160639.nyxoktszi5psl2cc@alap3.anarazel.de>
	<20170116032952.z2re55hcfhzbkmrm@alap3.anarazel.de>
	<20170116083316.2izqrxbvmyalazac@alap3.anarazel.de>
	<21924.1484593998@sss.pgh.pa.us>
	<CA+TgmoboiMYk1jTL-=2a0iukktCoDnKHMhrQ9za8JrMvkFdYUw@mail.gmail.com>
	<29207.1484675540@sss.pgh.pa.us>
	<20170117180324.dqgz23xaf6wtazb4@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Andres Freund <andres@anarazel.de> writes:
> I'd not have gone for SetResult if we didn't already have Result.  I'm
> not super happy ending up having Project in ProjectSet but not in the
> Result that end up doing the majority of the projection.  But eh, we can
> live with it.

Using Result for two completely different things is a wart though.  If we
had it to do over I think we'd define Result as a scan node that produces
rows from no input, and create a separate Project node for the case of
projecting from input tuples.  People are used to seeing Result in EXPLAIN
output, so it's not worth the trouble of changing that IMO, but we don't
have to use it as a model for more node types.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (110+ messages)  latest in thread

Message-ID: <30268.1484677082@sss.pgh.pa.us>
Permalink:  ../30268.1484677082@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/30268.1484677082@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, robertmhaas@gmail.com
  Subject: Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling)
  In-Reply-To: <30268.1484677082@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox