From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Remove configure --disable-float4-byval and --disable-float8-byval
Date: Sat, 02 Nov 2019 11:26:59 -0400
Message-ID: <30490.1572708419@sss.pgh.pa.us> (raw)
In-Reply-To: <b68834c1-2122-4b3d-11e4-b3938b83bab9@2ndquadrant.com>
References: <f3e1e576-2749-bbd7-2d57-3f9dcf75255a@2ndquadrant.com>
<15316.1572528990@sss.pgh.pa.us>
<CA+TgmoaCyw26S7wkTshAJKpjP5zfVnLiBSWYYvn5kT7rh3vrZg@mail.gmail.com>
<b68834c1-2122-4b3d-11e4-b3938b83bab9@2ndquadrant.com>
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2019-11-01 15:41, Robert Haas wrote:
>> On a related note, why do we store typbyval in the catalog anyway
>> instead of inferring it from typlen and maybe typalign? It seems like
>> a bad idea to record on disk the way we pass around values in memory,
>> because it means that a change to how values are passed around in
>> memory has ramifications for on-disk compatibility.
> This sounds interesting. It would remove a pg_upgrade hazard (in the
> long run).
> There is some backward compatibility to be concerned about.
Yeah. The point here is that typbyval specifies what the C functions
concerned with the datatype are expecting. We can't just up and say
"we're going to decide that for you".
I do get the point that supporting two different typbyval options
for float8 and related types is a nontrivial cost.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, robertmhaas@gmail.com
Subject: Re: Remove configure --disable-float4-byval and --disable-float8-byval
In-Reply-To: <30490.1572708419@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox