From: Alexander Lakhin <exclusion@gmail.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: HEAPDEBUGALL is broken
Date: Sun, 19 Apr 2020 23:00:00 +0300
Message-ID: <3070eb7d-e06d-31a0-5b68-4ae088fd146c@gmail.com> (raw)
In-Reply-To: <645c0646-4218-d4c3-409a-a7003a0c108d@2ndquadrant.com>
References: <645c0646-4218-d4c3-409a-a7003a0c108d@2ndquadrant.com>
Hello hackers,
19.04.2020 13:37, Tom Lane wrote:
>
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>> The HEAPDEBUGALL define has been broken since PG12 due to tableam
>> changes. Should we just remove this? It doesn't look very useful.
>> It's been around since Postgres95.
>> If we opt for removing: PG12 added an analogous HEAPAMSLOTDEBUGALL
>> (which still compiles correctly). Would we want to keep that?
>
> +1 for removing both. There are a lot of such debug "features"
> in the code, and few of them are worth anything IME.
To the point, I've tried to use HAVE_ALLOCINFO on master today and it
failed too:
$ CPPFLAGS="-DHAVE_ALLOCINFO" ./configure --enable-tap-tests
--enable-debug --enable-cassert >/dev/null && make -j16 >/dev/null
generation.c: In function ‘GenerationAlloc’:
generation.c:191:11: error: ‘GenerationContext {aka struct
GenerationContext}’ has no member named ‘name’
(_cxt)->name, (_chunk), (_chunk)->size)
^
generation.c:386:3: note: in expansion of macro ‘GenerationAllocInfo’
GenerationAllocInfo(set, chunk);
^~~~~~~~~~~~~~~~~~~
generation.c:191:11: error: ‘GenerationContext {aka struct
GenerationContext}’ has no member named ‘name’
(_cxt)->name, (_chunk), (_chunk)->size)
^
generation.c:463:2: note: in expansion of macro ‘GenerationAllocInfo’
GenerationAllocInfo(set, chunk);
^~~~~~~~~~~~~~~~~~~
Best regards,
Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: exclusion@gmail.com
Subject: Re: HEAPDEBUGALL is broken
In-Reply-To: <3070eb7d-e06d-31a0-5b68-4ae088fd146c@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox