From: Jaime Casanova <jcasanov@systemguards.com.ec>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Petr Jelinek <pjmodos@pjmodos.net>
Cc: Abhijit Menon-Sen <ams@toroid.org>
Cc: pgsql-hackers@postgresql.org
Subject: Re: GRANT ON ALL IN schema
Date: Sat, 10 Oct 2009 02:45:35 -0500
Message-ID: <3073cc9b0910100045qdcb2b3duabc05eb727ea0091@mail.gmail.com> (raw)
In-Reply-To: <603c8f070909270954n585e8e8am9eb1c187dec9fe19@mail.gmail.com>
References: <4A37BF63.50008@pjmodos.net>
<a301bfd90907170254re7dd52es9fedb007376d8055@mail.gmail.com>
<4A6059B4.5010004@pjmodos.net>
<4A607997.3030305@pjmodos.net>
<21542.1249492707@sss.pgh.pa.us>
<4A7F56A0.5060705@pjmodos.net>
<4A7F5853.5010506@pjmodos.net>
<20090920145011.GA24273@toroid.org>
<4AB75A51.5060807@pjmodos.net>
<603c8f070909270954n585e8e8am9eb1c187dec9fe19@mail.gmail.com>
On Sun, Sep 27, 2009 at 11:54 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>
> If this patch looks good now, can you mark it Ready for Committer in
> the CommitFest app? If there are any remaining issues, please post a
> further review.
>
while i'm not the reviewer this patch doesn't apply cleanly anymore...
some comments:
1) in docs for REVOKE you're omitting the SCHEMA part of the new syntax.
2) i think that getNamespacesObjectsOids() could be rewritten in something like:
+ {
+ List *objects = NIL;
+ ListCell *cell;
+ char *nspname;
+ Oid namespaceId;
+
+ foreach(cell, nspnames)
+ {
+ List *relations = NIL;
+
+ nspname = strVal(lfirst(cell));
+ namespaceId = LookupExplicitNamespace(nspname);
+ switch (objtype)
+ {
+ /* do what you need for every type of object here */
+
+ }
i think this is more readable
--
Atentamente,
Jaime Casanova
Soporte y capacitación de PostgreSQL
Asesoría y desarrollo de sistemas
Guayaquil - Ecuador
Cel. +59387171157
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: jcasanov@systemguards.com.ec, robertmhaas@gmail.com, pjmodos@pjmodos.net, ams@toroid.org
Subject: Re: GRANT ON ALL IN schema
In-Reply-To: <3073cc9b0910100045qdcb2b3duabc05eb727ea0091@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox