public inbox for [email protected]  

help / color / mirror / Atom feed

From: Daniel Gustafsson <[email protected]>
To: Andreas Karlsson <[email protected]>
Cc: Kyotaro Horiguchi <[email protected]>
Cc: [email protected]
Subject: Re: Possible typo in an error message
Date: Fri, 10 Jul 2026 10:05:33 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

> On 10 Jul 2026, at 09:31, Andreas Karlsson <[email protected]> wrote:
> 
> On 7/10/26 06:52, Kyotaro Horiguchi wrote:
>> While translating this message, I noticed the following error text:
>> parse_jsontable.c:644:
>>> errdetail("PATH name was %s not found in nested columns list.",
>> Is this perhaps meant to be
>> PATH name %s was not found in nested columns list.
>> instead?
> 
> Agreed, or maybe:
> 
> "Path name %s not found in nested columns list."
> 
> From what I can see both forms are used in our error messages.

I would favor "was not found" since the JSON_TABLE support has a similar
wording for missing PLAN clauses: "PLAN clause for nested path %s was not
found".  Consistency within a feature is good.

>> Also, I wasn't quite sure whether the uppercase "PATH" in messages
>> such as "PATH name" has any particular significance. For the
>> translation, I ended up treating it as the ordinary word "path", since
>> I couldn't tell whether it was intended to refer to the SQL keyword or
>> just the general concept.
> 
> Agreed, it does not look like it is a keyword so it should not be written in upper case.

I think it does refer to the PATH keyword in a NESTED PATH clause.  See below
for an example query from our regression tests:

SELECT * FROM JSON_TABLE(
       jsonb '[]', '$' AS path1
       COLUMNS (
               NESTED PATH '$' COLUMNS (
                       foo int PATH '$'
               )
       )
       PLAN DEFAULT (UNION)
) jt;

--
Daniel Gustafsson

view thread (5+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Possible typo in an error message
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox