pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Raúl Marín Rodríguez <rmrodriguez@carto.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] pgbench tap tests fail if the path contains a perl special character
Date: Fri, 18 Jan 2019 15:26:09 -0500
Message-ID: <32650.1547843169@sss.pgh.pa.us> (raw)
In-Reply-To: <29026.1547841766@sss.pgh.pa.us>
References: <201901181927.sbv5o72uu4cc@alvherre.pgsql>
	<29026.1547841766@sss.pgh.pa.us>

I wrote:
> So the patch as given should work.

... well, modulo the use of "@foo" where you should've used "$foo".
I don't know enough Perl to understand why that seemed to work, but
I do know it's not the right thing here.

Pushed with that correction.

			regards, tom lane




view thread (22+ messages)  latest in thread

Message-ID: <32650.1547843169@sss.pgh.pa.us>
Permalink:  ../32650.1547843169@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/32650.1547843169@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, rmrodriguez@carto.com
  Subject: Re: [PATCH] pgbench tap tests fail if the path contains a perl special character
  In-Reply-To: <32650.1547843169@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox