pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Davis <pgsql@j-davis.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Simon Riggs <simon@2ndquadrant.com>
Subject: Re: Extensible Rmgr for Table AMs
Date: Thu, 07 Apr 2022 10:05:15 -0400
Message-ID: <3280724.1649340315@sss.pgh.pa.us> (raw)
In-Reply-To: <2b6e4c0298b51a7dc32cd74b104f43f67880aedb.camel@j-davis.com>
References: <721eeefbd24c55015739ea75c0a233345e13e0b5.camel@j-davis.com>
	<20220201043938.r5s35loehsi27saj@jrouhaud>
	<20220201124550.gnhpw7iytc4da5tq@jrouhaud>
	<a4958c8fedd6905d4e323bc50b0b64509263d752.camel@j-davis.com>
	<20220203053418.lj5lzsp7yf2mvspw@jrouhaud>
	<CA+TgmobA=pPxjUS4FhUg+fkPdzPhMCkXJJReE=wM4vWuLOYsRw@mail.gmail.com>
	<20220204144801.wuwcansdzz3w2nn3@jrouhaud>
	<CA+TgmoYivHY9SzD3EEQtCDO+hpUJkD8TRG-gfBsLrMz7f43kJA@mail.gmail.com>
	<20220204145658.qtcmbsdawvn3lg3b@jrouhaud>
	<211518ee10e5c37014d3a11d744c1aadc43e9f2c.camel@j-davis.com>
	<20220328180045.nz3nuy5ea2xpxuax@alap3.anarazel.de>
	<1ae76bc9910df2fc495173b9bf7ed31223721efe.camel@j-davis.com>
	<CALj2ACWCibq2jkb0dWG0Ws1BokB-Bv+aEbWgUQJVH8me_E5EGg@mail.gmail.com>
	<3ac6b783ea57e1310c824e436ab693b304877cf8.camel@j-davis.com>
	<CALj2ACWxMsQfjzWRLb7jarGsnGXJX_PHvBz4tni-P7tDbpO3gQ@mail.gmail.com>
	<2b6e4c0298b51a7dc32cd74b104f43f67880aedb.camel@j-davis.com>

Jeff Davis <pgsql@j-davis.com> writes:
> I'm happy with this patch and I committed it.

wrasse is less happy:

ccache /opt/developerstudio12.6/bin/cc  -m64 -Xa -v -O  findtimezone.o initdb.o localtime.o -L../../../src/port -L../../../src/common -L../../../src/fe_utils -lpgfeutils -L../../../src/common -lpgcommon -L../../../src/port -lpgport -L../../../src/interfaces/libpq -lpq   -L/home/nm/sw/nopath/uuid-64/lib -L/home/nm/sw/nopath/openldap-64/lib -Wl,--as-needed -Wl,-R'/home/nm/farm/studio64v12_6/HEAD/inst/lib'  -lpgcommon -lpgport -lxslt -lxml2 -lpam -lssl -lcrypto -lgssapi_krb5 -lz -lreadline -ltermcap -lnsl -lsocket -lm  -o initdb
Undefined			first referenced
 symbol  			    in file
RmgrTable                           initdb.o
ld: fatal: symbol referencing errors

I think this means the static inline functions you added in
xlog_internal.h need to be wrapped in #ifndef FRONTEND.

			regards, tom lane





view thread (32+ messages)  latest in thread

Message-ID: <3280724.1649340315@sss.pgh.pa.us>
Permalink:  ../3280724.1649340315@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3280724.1649340315@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql@j-davis.com, bharath.rupireddyforpostgres@gmail.com, andres@anarazel.de, rjuju123@gmail.com, robertmhaas@gmail.com, amit.kapila16@gmail.com, simon@2ndquadrant.com
  Subject: Re: Extensible Rmgr for Table AMs
  In-Reply-To: <3280724.1649340315@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox