From: Konstantin Knizhnik <k.knizhnik@postgrespro.ru>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] Cached plans and statement generalization
Date: Mon, 8 Jul 2019 22:32:38 +0300
Message-ID: <3304c34b-4a9c-909c-4ee1-d8e7f6dcb2de@postgrespro.ru> (raw)
In-Reply-To: <CA+hUKGKuxM94eVyBii=0e1bWpa-A05f2L6H-JSij0H5o7t+ZqA@mail.gmail.com>
References: <CA+TgmoZAHc4wqL3HvVmTd87s=bobp_8_7R9H=B_kH6q4GcA=Yg@mail.gmail.com>
<9A6E5062D5D4DB458C80C2B2920BD71D5C5111@g01jpexmbkw23>
<3a054e51-448e-a66d-074e-099a3f3f62b2@postgrespro.ru>
<9A6E5062D5D4DB458C80C2B2920BD71D5ECEB5@g01jpexmbkw23>
<CA+q6zcW4bL=pr3_YjkKtVhHUN5qfd7kxTFUWqCiavA0ROjBu0Q@mail.gmail.com>
<9A6E5062D5D4DB458C80C2B2920BD71D610148@g01jpexmbkw23>
<CA+q6zcWKsaiFz6oWA1JXdJWNwSSk+wUyuOVO2nryCCSxrr3KRw@mail.gmail.com>
<EDA4195584F5064680D8130B1CA91C453D0182@G01JPEXMBYT04>
<6ea1db86-b300-b57c-0f9d-a55dd3966175@postgrespro.ru>
<9A6E5062D5D4DB458C80C2B2920BD71D6820CB@g01jpexmbkw23>
<554d0730-f6fc-d1be-fe78-e63973ec621f@postgrespro.ru>
<35be0423-36bc-cadc-bef8-02d475751f7d@postgrespro.ru>
<7603a101-6b79-2328-2b4b-3bc3217992e5@postgrespro.ru>
<CA+hUKGJK2GZewMumkXtPjyATMu2tyEmg53R23WCETY=y48RxQw@mail.gmail.com>
<f71ca2cb-b2c0-d6ca-4532-822b25f1f81e@postgrespro.ru>
<CA+hUKGKuxM94eVyBii=0e1bWpa-A05f2L6H-JSij0H5o7t+ZqA@mail.gmail.com>
On 08.07.2019 2:23, Thomas Munro wrote:
> On Tue, Jul 2, 2019 at 3:29 AM Konstantin Knizhnik
> <k.knizhnik@postgrespro.ru> wrote:
>> Attached please find rebased version of the patch.
>> Also this version can be found in autoprepare branch of this repository
>> https://github.com/postgrespro/postgresql.builtin_pool.git
>> on github.
> Thanks. I haven't looked at the code but this seems like interesting
> work and I hope it will get some review. I guess this is bound to use
> a lot of memory. I guess we'd eventually want to figure out how to
> share the autoprepared plan cache between sessions, which is obviously
> a whole can of worms.
>
> A couple of trivial comments with my CF manager hat on:
>
> 1. Can you please fix the documentation? It doesn't build.
> Obviously reviewing the goals, design and implementation are more
> important than the documentation at this point, but if that is fixed
> then the CF bot will be able to run check-world every day and we might
> learn something about the code.
> 2. Accidental editor junk included: src/include/catalog/pg_proc.dat.~1~
Sorry, are you tests autoprepare-16.patch I have sent in the last e-mail?
I can not reproduce the problem with building documentation:
knizhnik@xps:~/postgresql/doc$ make
make -C ../src/backend generated-headers
make[1]: Entering directory '/home/knizhnik/postgresql/src/backend'
make -C catalog distprep generated-header-symlinks
make[2]: Entering directory '/home/knizhnik/postgresql/src/backend/catalog'
make[2]: Nothing to be done for 'distprep'.
make[2]: Nothing to be done for 'generated-header-symlinks'.
make[2]: Leaving directory '/home/knizhnik/postgresql/src/backend/catalog'
make -C utils distprep generated-header-symlinks
make[2]: Entering directory '/home/knizhnik/postgresql/src/backend/utils'
make[2]: Nothing to be done for 'distprep'.
make[2]: Nothing to be done for 'generated-header-symlinks'.
make[2]: Leaving directory '/home/knizhnik/postgresql/src/backend/utils'
make[1]: Leaving directory '/home/knizhnik/postgresql/src/backend'
make -C src all
make[1]: Entering directory '/home/knizhnik/postgresql/doc/src'
make -C sgml all
make[2]: Entering directory '/home/knizhnik/postgresql/doc/src/sgml'
/usr/bin/xmllint --path . --noout --valid postgres.sgml
/usr/bin/xsltproc --path . --stringparam pg.version '12devel'
stylesheet.xsl postgres.sgml
cp ./stylesheet.css html/
touch html-stamp
/usr/bin/xmllint --path . --noout --valid postgres.sgml
/usr/bin/xsltproc --path . --stringparam pg.version '12devel'
stylesheet-man.xsl postgres.sgml
touch man-stamp
make[2]: Leaving directory '/home/knizhnik/postgresql/doc/src/sgml'
make[1]: Leaving directory '/home/knizhnik/postgresql/doc/src'
Also autoporepare-16.patch doesn't include any junk
src/include/catalog/pg_proc.dat.~1~
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: k.knizhnik@postgrespro.ru, thomas.munro@gmail.com
Subject: Re: [HACKERS] Cached plans and statement generalization
In-Reply-To: <3304c34b-4a9c-909c-4ee1-d8e7f6dcb2de@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox