pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Chapman Flack <chap@anastigmatix.net>
Cc: pgsql-hackers@lists.postgresql.org, Mark Wong <markwkm@gmail.com>
Cc: Konstantina Skovola <konskov@gmail.com>
Subject: Re: trigger example for plsample
Date: Thu, 07 Apr 2022 18:29:53 -0400
Message-ID: <3528727.1649370593@sss.pgh.pa.us> (raw)
In-Reply-To: <164936745890.1158.5394289322705772875.pgcf@coridan.postgresql.org>
References: <Yd8Cz22eHi80XS30@workstation-mark-wong>
	<Yk8OFtSyKDLLhjPW@workstation-mark-wong>
	<164936745890.1158.5394289322705772875.pgcf@coridan.postgresql.org>

Chapman Flack <chap@anastigmatix.net> writes:
> v4 looks good to me.

Pushed with very minor editorialization.  Mainly, I undid the
decision to stop printing the function source text, on the
grounds that (1) it falsified the comment immediately above,
and (2) if you have to print it anyway to avoid compiler warnings,
you're just creating confusing inconsistency between the two
handler functions.

			regards, tom lane





view thread (11+ messages)  latest in thread

Message-ID: <3528727.1649370593@sss.pgh.pa.us>
Permalink:  ../3528727.1649370593@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3528727.1649370593@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, chap@anastigmatix.net, markwkm@gmail.com, konskov@gmail.com
  Subject: Re: trigger example for plsample
  In-Reply-To: <3528727.1649370593@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox