From: Mark Wong <markwkm@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Chapman Flack <chap@anastigmatix.net>
Cc: pgsql-hackers@lists.postgresql.org, Konstantina Skovola <konskov@gmail.com>
Subject: Re: trigger example for plsample
Date: Fri, 8 Apr 2022 17:34:00 +0000
Message-ID: <YlByCLvap6LceaVq@g> (raw)
In-Reply-To: <3528727.1649370593@sss.pgh.pa.us>
References: <Yd8Cz22eHi80XS30@workstation-mark-wong>
<Yk8OFtSyKDLLhjPW@workstation-mark-wong>
<164936745890.1158.5394289322705772875.pgcf@coridan.postgresql.org>
<3528727.1649370593@sss.pgh.pa.us>
On Thu, Apr 07, 2022 at 06:29:53PM -0400, Tom Lane wrote:
> Chapman Flack <chap@anastigmatix.net> writes:
> > v4 looks good to me.
>
> Pushed with very minor editorialization. Mainly, I undid the
> decision to stop printing the function source text, on the
> grounds that (1) it falsified the comment immediately above,
> and (2) if you have to print it anyway to avoid compiler warnings,
> you're just creating confusing inconsistency between the two
> handler functions.
Sounds good to me, thanks!
Regards,
Mark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: markwkm@gmail.com, tgl@sss.pgh.pa.us, chap@anastigmatix.net, konskov@gmail.com
Subject: Re: trigger example for plsample
In-Reply-To: <YlByCLvap6LceaVq@g>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox