pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrei Lepikhov <lepihov@gmail.com>
To: Yurii Rashkovskii <yrashk@omnigres.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Add Postgres module info
Date: Fri, 27 Dec 2024 08:34:00 +0700
Message-ID: <35f29bde-ccc7-41b3-8c13-6ff30c196a93@gmail.com> (raw)
In-Reply-To: <CAG=VW16Zr028+S7+sXVz+MUzyYyA5iKrokfZc8xY6oOpdYhUdA@mail.gmail.com>
References: <dd4d1b59-d0fe-49d5-b28f-1e463b68fa32@gmail.com>
	<506788.1733941263@sss.pgh.pa.us>
	<2c215c98-f713-4c5b-b21a-a4b8fa41890b@gmail.com>
	<556341.1733967371@sss.pgh.pa.us>
	<0844622e-9967-409a-8038-470a36f1039c@gmail.com>
	<CAG=VW14ZmKDcxYs7irSvhVS+JeDg2W_gyR++L2GXEpzVVYQ+Yw@mail.gmail.com>
	<8b81a3c0-761f-4cfb-97c6-68819fe4d282@gmail.com>
	<982748.1734059835@sss.pgh.pa.us>
	<0e82bf8c-ae70-498d-861e-dba2bb154cad@gmail.com>
	<CAG=VW16Zr028+S7+sXVz+MUzyYyA5iKrokfZc8xY6oOpdYhUdA@mail.gmail.com>

On 12/24/24 10:42, Yurii Rashkovskii wrote:
> On Mon, Dec 16, 2024 at 12:02 PM Andrei Lepikhov <lepihov@gmail.com 
> I've reviewed the patch, and it is great that you support more flexible 
> versioning now. I am just wondering a bit about the case where `minfo- 
>  >name` can be `NULL` but `minfo->version` isn't, or where both are 
> `NULL` – should we skip any of these?
Depends. I wrote code that way so as not to restrict a maintainer by 
initialising all the fields; remember, it may grow in the future.
But I am open to changing that logic. Do you have any specific rule on 
which fields may be empty and that must be initialised? Do you think all 
fields maintainer must fill with non-zero-length constants?

Also, I've added this patch to commitfest:
https://commitfest.postgresql.org/51/5465/

-- 
regards, Andrei Lepikhov





view thread (52+ messages)  latest in thread

Message-ID: <35f29bde-ccc7-41b3-8c13-6ff30c196a93@gmail.com>
Permalink:  ../35f29bde-ccc7-41b3-8c13-6ff30c196a93@gmail.com/
Also on:    postgresql.org/message-id/35f29bde-ccc7-41b3-8c13-6ff30c196a93@gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: lepihov@gmail.com, yrashk@omnigres.com, tgl@sss.pgh.pa.us
  Subject: Re: Add Postgres module info
  In-Reply-To: <35f29bde-ccc7-41b3-8c13-6ff30c196a93@gmail.com>
  References: <dd4d1b59-d0fe-49d5-b28f-1e463b68fa32@gmail.com> <506788.1733941263@sss.pgh.pa.us> <2c215c98-f713-4c5b-b21a-a4b8fa41890b@gmail.com> <556341.1733967371@sss.pgh.pa.us> <0844622e-9967-409a-8038-470a36f1039c@gmail.com> <CAG=VW14ZmKDcxYs7irSvhVS+JeDg2W_gyR++L2GXEpzVVYQ+Yw@mail.gmail.com> <8b81a3c0-761f-4cfb-97c6-68819fe4d282@gmail.com> <982748.1734059835@sss.pgh.pa.us> <0e82bf8c-ae70-498d-861e-dba2bb154cad@gmail.com> <CAG=VW16Zr028+S7+sXVz+MUzyYyA5iKrokfZc8xY6oOpdYhUdA@mail.gmail.com> <35f29bde-ccc7-41b3-8c13-6ff30c196a93@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox