pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Tristan Partin <tristan@partin.io>
Cc: Mark Wong <markwkm@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: updates for handling optional argument in system functions
Date: Fri, 03 Jul 2026 10:15:02 -0400
Message-ID: <3857325.1783088102@sss.pgh.pa.us> (raw)
In-Reply-To: <CAHGQGwEx=jiyoJmkb5EaTrq=oMLFpCC_tiso0PkMAGY_4UqSrA@mail.gmail.com>
References: <aTiwu9o8vBkLreAL@ltdrgnflg2>
	<ac63G6p1LAdbsca0@ltdrgnflg2>
	<6de20662-36fd-4e00-a0b0-75d1e9deb5c8@proxel.se>
	<adWWX4jFbxib8oQ1@ltdrgnflg2>
	<b6808c92-9531-4772-aeba-f60535d68b72@proxel.se>
	<adaaL5VD9bfipZQI@ltdrgnflg2>
	<aiMuFBFYLAWQC_5Z@ltdrgnflg2>
	<DJ1F5L6XMENK.ABIOKCQQQ0FZ@partin.io>
	<airKicKeRJaaoMF5@ltdrgnflg2>
	<DJCBVXBWYQ55.2V718KGAFOW81@partin.io>
	<CAHGQGwEx=jiyoJmkb5EaTrq=oMLFpCC_tiso0PkMAGY_4UqSrA@mail.gmail.com>

Fujii Masao <masao.fujii@gmail.com> writes:
> I have one question, though.

> Suppose a user executes GRANT or REVOKE on pg_get_ruledef(oid), then
> creates a dump with pg_dump. If that dump is restored into a newer
> server where these patches have been applied, the restore would fail
> because pg_get_ruledef(oid) no longer exists.

> Is that acceptable (this means that users need to handle the restore
> failure), or should pg_dump handle this case specially?

I wouldn't blink an eye at that.  There's no obvious use-case for
someone to mess with the permissions on that function.  Even
if there were, I don't think it'd be reasonable for pg_dump to
try to patch it up.  (I'm not sure that pg_dump would dump such
grants in the first place.)

			regards, tom lane





view thread (32+ messages)  latest in thread

Message-ID: <3857325.1783088102@sss.pgh.pa.us>
Permalink:  ../3857325.1783088102@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3857325.1783088102@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, masao.fujii@gmail.com, tristan@partin.io, markwkm@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: updates for handling optional argument in system functions
  In-Reply-To: <3857325.1783088102@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox