From: Jeff Davis <pgsql@j-davis.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_dump --with-* options
Date: Sat, 02 Aug 2025 08:30:07 -0700
Message-ID: <3860919f09b1edc31f5c19adb3260836afd3283c.camel@j-davis.com> (raw)
In-Reply-To: <aI1Dz1DXe_gaqwOZ@nathan>
References: <7cc52488-f876-4ad3-affd-6e4b0ef0cb09@eisentraut.org>
<aEMLzPQtjRbj2R7X@nathan>
<CA+TgmoactJEUHeXuxHLKNXHzm6-XrQFigPur-4nHTMFSiSRkiQ@mail.gmail.com>
<aErpuM6RXSlK1FBW@nathan>
<7bf0246542713d80f12c738c1d365d1365750c18.camel@j-davis.com>
<5e398522803da9bf3f9fc33ca43084ec21ab0fcd.camel@j-davis.com>
<aFLenfMRS9jFINxq@nathan>
<031558c60e84362898922caa6a90587e7fdf2a57.camel@j-davis.com>
<f379d0aeefe8effe13302a436bc28f549f09e924.camel@j-davis.com>
<40cedfc22da152928a74d472708aaadb8855d8d9.camel@j-davis.com>
<aI1Dz1DXe_gaqwOZ@nathan>
On Fri, 2025-08-01 at 17:46 -0500, Nathan Bossart wrote:
> On Fri, Aug 01, 2025 at 12:42:16PM -0700, Jeff Davis wrote:
> > - <term><option>--with-statistics</option></term>
> > + <term><option>--statistics</option></term>
>
> > - <term><option>--with-statistics</option></term>
> > + <term><option>--statistics</option></term>
>
> > - <term><option>--with-statistics</option></term>
> > + <term><option>--statistics</option></term>
>
> nitpick: --statistics should be moved to maintain alphabetical
> ordering.
>
Thank you. I committed this and closed the Open Item.
I did not address the following issues:
* Did not change default to on: there was no consensus on this point,
and the default-off opinions were stronger. We may be able to revisit
for PG19.
* Did not add --include syntax: no patch and no consensus on the
details.
* Did not remove redundant --no-statistics option for pg_dump and
redundant --statistics option for pg_restore: kept for consistency
between pg_dump and pg_restore, and to allow us to potentially change
to default-on in the future.
If someone feels one of these needs to be addressed in PG18, let me
know.
Regards,
Jeff Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pgsql@j-davis.com, nathandbossart@gmail.com, robertmhaas@gmail.com, peter@eisentraut.org
Subject: Re: pg_dump --with-* options
In-Reply-To: <3860919f09b1edc31f5c19adb3260836afd3283c.camel@j-davis.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox