From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Ian Lawrence Barwick <barwick@gmail.com>
To: Paul Jungwirth <pj@illuminatedcomputing.com>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Think-o in foreign key comments
Date: Wed, 7 Dec 2022 17:11:52 +0100
Message-ID: <3c87f4db-560b-d9b7-77f4-bdb67e0d122b@enterprisedb.com> (raw)
In-Reply-To: <CAB8KJ=h=X0QgK_MciFR8r1dpXpsmkBxSkuK75+okOG3P5T2cnA@mail.gmail.com>
References: <6a7c7338-1aa2-4689-d171-0b0b294fdd84@illuminatedcomputing.com>
<CAB8KJ=h=X0QgK_MciFR8r1dpXpsmkBxSkuK75+okOG3P5T2cnA@mail.gmail.com>
On 03.12.22 05:59, Ian Lawrence Barwick wrote:
> 2022年12月3日(土) 7:19 Paul Jungwirth <pj@illuminatedcomputing.com>:
>> I noticed a few places in the new foreign key code where a comment says
>> "the ON DELETE SET NULL/DELETE clause". I believe it should say "ON
>> DELETE SET NULL/DEFAULT".
>>
>> These comments were added in d6f96ed94e7, "Allow specifying column list
>> for foreign key ON DELETE SET actions." Here is a patch to correct them.
>
> LGTM.
>
> I do notice the same patch adds the function "validateFkOnDeleteSetColumns"
> but the name in the comment preceding it is "validateFkActionSetColumns",
> might as well fix that the same time.
Committed with that addition and backpatched to PG15.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, barwick@gmail.com, pj@illuminatedcomputing.com
Subject: Re: Think-o in foreign key comments
In-Reply-To: <3c87f4db-560b-d9b7-77f4-bdb67e0d122b@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox