From: Paul Jungwirth <pj@illuminatedcomputing.com>
To: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Think-o in foreign key comments
Date: Fri, 2 Dec 2022 14:18:51 -0800
Message-ID: <6a7c7338-1aa2-4689-d171-0b0b294fdd84@illuminatedcomputing.com> (raw)
Hello,
I noticed a few places in the new foreign key code where a comment says
"the ON DELETE SET NULL/DELETE clause". I believe it should say "ON
DELETE SET NULL/DEFAULT".
These comments were added in d6f96ed94e7, "Allow specifying column list
for foreign key ON DELETE SET actions." Here is a patch to correct them.
I don't think you usually create a commitfest entry for tiny fixes like
this, right? But if you'd like one please let me know and I'll add it.
Yours,
--
Paul ~{:-)
pj@illuminatedcomputing.com
Attachments:v1-0001-Fix-FK-comment-think-o.patch (text/x-patch, 2.1K) download
From dc5e317762266b93bfa44bb303fe1882853d8de7 Mon Sep 17 00:00:00 2001
From: "Paul A. Jungwirth" <pj@illuminatedcomputing.com>
Date: Fri, 2 Dec 2022 14:02:55 -0800
Subject: [PATCH v1] Fix FK comment think-o
---
src/backend/commands/tablecmds.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.cindex 3e83f375b5..716793e157 100644--- a/src/backend/commands/tablecmds.c+++ b/src/backend/commands/tablecmds.c@@ -9467,10 +9467,10 @@ validateFkOnDeleteSetColumns(int numfks, const int16 *fkattnums,
* numfks is the number of columns in the foreign key
* pkattnum is the attnum array of referenced attributes.
* fkattnum is the attnum array of referencing attributes.
- * numfkdelsetcols is the number of columns in the ON DELETE SET NULL/DELETE+ * numfkdelsetcols is the number of columns in the ON DELETE SET NULL/DEFAULT
* (...) clause
* fkdelsetcols is the attnum array of the columns in the ON DELETE SET
- * NULL/DELETE clause+ * NULL/DEFAULT clause
* pf/pp/ffeqoperators are OID array of operators between columns.
* old_check_ok signals that this constraint replaces an existing one that
* was already validated (thus this one doesn't need validation).
@@ -9686,10 +9686,10 @@ addFkRecurseReferenced(List **wqueue, Constraint *fkconstraint, Relation rel,
* pkattnum is the attnum array of referenced attributes.
* fkattnum is the attnum array of referencing attributes.
* pf/pp/ffeqoperators are OID array of operators between columns.
- * numfkdelsetcols is the number of columns in the ON DELETE SET NULL/DELETE+ * numfkdelsetcols is the number of columns in the ON DELETE SET NULL/DEFAULT
* (...) clause
* fkdelsetcols is the attnum array of the columns in the ON DELETE SET
- * NULL/DELETE clause+ * NULL/DEFAULT clause
* old_check_ok signals that this constraint replaces an existing one that
* was already validated (thus this one doesn't need validation).
* lockmode is the lockmode to acquire on partitions when recursing.
--
2.25.1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pj@illuminatedcomputing.com
Subject: Re: Think-o in foreign key comments
In-Reply-To: <6a7c7338-1aa2-4689-d171-0b0b294fdd84@illuminatedcomputing.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox