public inbox for [email protected]  

help / color / mirror / Atom feed
From: Florents Tselai <[email protected]>
To: David E. Wheeler <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Alexander Korotkov <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part
Date: Sat, 24 May 2025 19:51:32 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CA+v5N40sJF39m0v7h=QN86zGp0CUf9F1WKasnZy9nNVj_VhCZQ@mail.gmail.com>
	<[email protected]>
	<CAPpHfdtGhn_5jfLoepOScyqT+FXYB9QtV-OEprychDcMJco7mw@mail.gmail.com>
	<CA+v5N42PVJH3HbwLE1yC75XR6E5zGnCCdtSUXfgFwtGyPP8XYg@mail.gmail.com>
	<CA+Tgmob03B6h1SMsi7vs9uOX+vrqg_tyhh--mKC3BaTJ08qKYA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>



> On 24 May 2025, at 7:08 PM, David E. Wheeler <[email protected]> wrote:
> 
> On May 23, 2025, at 13:52, Tom Lane <[email protected]> wrote:
> 
>>> I assume you mean that they’re set at initdb time, so there’s no mutability concern?
>> 
>> Yeah, I think Peter's right and I'm wrong.  Obviously this ties into
>> our philosophical debate about how immutable is immutable.  But as
>> long as the functions only depend on locale settings that are fixed
>> at database creation, I think it's okay to consider them immutable.
>> 
>> If you were, say, depending on LC_NUMERIC, it would clearly be unsafe
>> to consider that immutable, so I'm not quite sure if this is the end
>> of the discussion.  But for what's mentioned in the thread title,
>> I think we only care about LC_CTYPE.
> 
> Oh, so maybe all this is moot, and Florents can go ahead and add support for the functions to the non-_tz functions?
> 


I think the patch is still in reasonably good shape and hasn’t changed much since September 24.
So yes, I’d hope there are still some valid points to consider or improve.
Otherwise, I’ll have only myself to blame for not pushing harder before the feature freeze. 😅

view thread (56+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox