From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tels <nospam-pg-abuse@bloodgate.com>
Cc: Victor Wagner <vitus@wagner.pp.ru>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Non-portable shell code in pg_upgrade tap tests
Date: Sat, 21 Jul 2018 11:29:27 -0400
Message-ID: <4263.1532186967@sss.pgh.pa.us> (raw)
In-Reply-To: <c96303c04c360bbedaa04f90f515745b.squirrel@sm.webmail.pair.com>
References: <20180720153820.69e9ae6c@fafnir.local.vm>
<17833.1532096747@sss.pgh.pa.us>
<20180720175508.07776219@fafnir.local.vm>
<c96303c04c360bbedaa04f90f515745b.squirrel@sm.webmail.pair.com>
"Tels" <nospam-pg-abuse@bloodgate.com> writes:
> + *) if [ `find ${PGDATA} -type f ! -perm 640 | wc -l` -ne 0 ]; then
> Shouldn't ${PGDATA} in the above as argument to find be quoted, otherwise
> the shell would get confused if it contains spaces or other special
> characters?
Hmm. Yeah, probably. I don't think this script is meant to be run with
arbitrary values of PGDATA, but most of the other uses are quoted, so
for consistency's sake this should be too.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, nospam-pg-abuse@bloodgate.com, vitus@wagner.pp.ru
Subject: Re: Non-portable shell code in pg_upgrade tap tests
In-Reply-To: <4263.1532186967@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox