pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Arthur Zakirov <a.zakirov@postgrespro.ru>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PROPOSAL] Shared Ispell dictionaries
Date: Sun, 20 Jan 2019 23:15:35 +0100
Message-ID: <42b1ded6-fd44-5975-77e4-72ada1f134a2@2ndquadrant.com> (raw)
In-Reply-To: <e0a25563-cbb1-7089-8c25-44668cfb031b@postgrespro.ru>
References: <20180322105603.GA23544@zakirov.localdomain>
	<28250.1521924996@sss.pgh.pa.us>
	<ada73d07-6c88-acab-7e31-75b2eb724d24@2ndquadrant.com>
	<25186.1521951490@sss.pgh.pa.us>
	<20180325205408.GA19457@arthur.localdomain>
	<27296.1522078068@sss.pgh.pa.us>
	<20180327121954.GA12726@zakirov.localdomain>
	<CA+TgmoaR_fVd_u60mA-PHO=J1u0PmdVGOt9WaxZ1UYuGq276oQ@mail.gmail.com>
	<20180516113631.GA29544@zakirov.localdomain>
	<20180614084015.GA12451@zakirov.localdomain>
	<20181001092204.GA5071@zakirov.localdomain>
	<68aaaff6-0efe-c14b-7aee-fb110bb97f69@2ndquadrant.com>
	<337f7a55-58b8-4fcc-a933-5e7799fa6882@postgrespro.ru>
	<e0a25563-cbb1-7089-8c25-44668cfb031b@postgrespro.ru>

On 1/17/19 3:15 PM, Arthur Zakirov wrote:
> I attached files of new version of the patch, I applied your tweaks.
> 
>> XXX All dictionaries, but only when there's invalid dictionary?
> 
> I've made a little optimization. I introduced hashvalue into
> TSDictionaryCacheEntry. Now released only DSM of altered or dropped
> dictionaries.
> 
>>  > /* XXX not really a pointer, so the name is misleading */
>>
>> I think we don't need DictPointerData struct anymore, because only
>> ts_dict_shmem_release function needs it (see comments above) and we only
>> need it to hash search. I'll move all fields of DictPointerData to
>> TsearchDictKey struct.
> 
> I was wrong, DictInitData also needs DictPointerData. I didn't remove
> DictPointerData, I renamed it to DictEntryData. Hope that it is a more
> appropriate name.
> 

Thanks. I've reviewed v17 today and I haven't discovered any new issues
so far. If everything goes fine and no one protests, I plan to get it
committed over the next week or so.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




view thread (108+ messages)  latest in thread

Message-ID: <42b1ded6-fd44-5975-77e4-72ada1f134a2@2ndquadrant.com>
Permalink:  ../42b1ded6-fd44-5975-77e4-72ada1f134a2@2ndquadrant.com/
Also on:    postgresql.org/message-id/42b1ded6-fd44-5975-77e4-72ada1f134a2@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tomas.vondra@2ndquadrant.com, a.zakirov@postgrespro.ru, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, pavel.stehule@gmail.com, andres@anarazel.de
  Subject: Re: [PROPOSAL] Shared Ispell dictionaries
  In-Reply-To: <42b1ded6-fd44-5975-77e4-72ada1f134a2@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox