pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Stephen Frost <sfrost@snowman.net>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: David Steele <david@pgmasters.net>
Cc: Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: PATCH: Make pg_stop_backup() archive wait optional
Date: Wed, 22 Mar 2017 16:42:22 -0400
Message-ID: <4f41afe5-0947-ce53-e985-971bc774169b@2ndquadrant.com> (raw)
In-Reply-To: <20170322191451.GY9812@tamriel.snowman.net>
References: <CA+TgmoZfjF2k6N8Rfga20bXxnRAttuz8N6dvxeOu=t3j0FYYsg@mail.gmail.com>
	<081cbf08-35c1-4580-8c31-3ae70b507fb1@pgmasters.net>
	<0A3221C70F24FB45833433255569204D1F6B3F95@G01JPEXMBYT05>
	<0A3221C70F24FB45833433255569204D1F6B5134@G01JPEXMBYT05>
	<49d70e8e-33bf-2390-e717-ba9562621aa4@pgmasters.net>
	<0A3221C70F24FB45833433255569204D1F6B607B@G01JPEXMBYT05>
	<CAHGQGwHRmE+db96=9FDPLVxWRN0gSf6kU7nM6-WnEKot2OanOg@mail.gmail.com>
	<ee92e800-f983-c3a7-ddae-92acae162832@pgmasters.net>
	<20170322153703.GK9812@tamriel.snowman.net>
	<CAHGQGwFd+7D5UPwLLCW3=5mmDzXOKN56gySRUqdRzaeVK_L2HQ@mail.gmail.com>
	<20170322191451.GY9812@tamriel.snowman.net>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 3/22/17 15:14, Stephen Frost wrote:
>> -SELECT * FROM pg_stop_backup(false);
>> +SELECT * FROM pg_stop_backup(false [, true ]);
>>
>> I think that it's better to get rid of "[" and "]" from the above because
>> IMO this should be the command example that users actually can run.
> Using the '[' and ']' are how all of the optional arguments are
> specified in the documentation, see things like current_setting() in our
> existing documentation:

In the synopsis, but not in concrete examples.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (31+ messages)  latest in thread

Message-ID: <4f41afe5-0947-ce53-e985-971bc774169b@2ndquadrant.com>
Permalink:  ../4f41afe5-0947-ce53-e985-971bc774169b@2ndquadrant.com/
Also on:    postgresql.org/message-id/4f41afe5-0947-ce53-e985-971bc774169b@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, sfrost@snowman.net, masao.fujii@gmail.com, david@pgmasters.net, tsunakawa.takay@jp.fujitsu.com, michael.paquier@gmail.com
  Subject: Re: PATCH: Make pg_stop_backup() archive wait optional
  In-Reply-To: <4f41afe5-0947-ce53-e985-971bc774169b@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox