pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: David Steele <david@pgbackrest.org>
To: Benoit Lobréau <benoit.lobreau@dalibo.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andrey M. Borodin <x4mmm@yandex-team.ru>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Fix logging for invalid recovery timeline
Date: Sat, 22 Feb 2025 16:17:44 +0000 (UTC)
Message-ID: <5336e68a-30d0-473f-a0a0-9e61cd9a5a63@pgbackrest.org> (raw)
In-Reply-To: <173a9a4a-bad3-4a42-91e1-637f70e9512f@dalibo.com>
References: <c3d617d4-1696-4aa7-8a4d-5a7d19cc5618@pgbackrest.org>
	<C748635E-B2FF-4813-B035-AE670832B9FD@yandex-team.ru>
	<d0b27c08-d30f-4a1d-990d-5c90ca0a650a@pgbackrest.org>
	<4ed10bc8-5513-4d8e-8643-8abcaa08336d@dalibo.com>
	<2765f538-b06f-4e57-bcb2-9ca1dc6f487d@pgbackrest.org>
	<Z7aJU2_ZAplbpTsL@paquier.xyz>
	<6273ef0b-033b-4ac7-ab05-71a04e7ac626@pgbackrest.org>
	<173a9a4a-bad3-4a42-91e1-637f70e9512f@dalibo.com>

On 2/21/25 09:09, Benoit Lobréau wrote:
> On 2/20/25 4:40 PM, David Steele wrote:
>> Benoit -- this was your idea. Did you want to submit a patch yourself?
> 
> Here is an attempt at that. I kept the wording I used above. Is it fine 
> to repeat the whole ereport block twice?

I think for translation purposes this is probably how it needs to be but 
I wonder if we could do something like:

errdetail("Latest checkpoint in %s is at %X/%X <...>",
           haveBackupLabel ? "pg_control" ? "backup_label",

I'll defer to Michael on that.

In general this patch and the new messages look good to me, though.

Regards,
-David





view thread (16+ messages)  latest in thread

Message-ID: <5336e68a-30d0-473f-a0a0-9e61cd9a5a63@pgbackrest.org>
Permalink:  ../5336e68a-30d0-473f-a0a0-9e61cd9a5a63@pgbackrest.org/
Also on:    postgresql.org/message-id/5336e68a-30d0-473f-a0a0-9e61cd9a5a63@pgbackrest.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: david@pgbackrest.org, benoit.lobreau@dalibo.com, michael@paquier.xyz, x4mmm@yandex-team.ru
  Subject: Re: Fix logging for invalid recovery timeline
  In-Reply-To: <5336e68a-30d0-473f-a0a0-9e61cd9a5a63@pgbackrest.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox