pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: David Geier <geidav.pg@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Consistently use palloc_object() and palloc_array()
Date: Tue, 02 Dec 2025 19:40:46 -0500
Message-ID: <534126.1764722446@sss.pgh.pa.us> (raw)
In-Reply-To: <aS-F6LkeDBEly9nz@paquier.xyz>
References: <ad0748d4-3080-436e-b0bc-ac8f86a3466a@gmail.com>
	<ED821EDD-6A1B-45B8-9005-31BCFFCB5A48@gmail.com>
	<a29b0cd9-576f-486f-ba45-5139ee33adcf@gmail.com>
	<524587.1764365323@sss.pgh.pa.us>
	<1e7f0c17-a965-4d5b-ad88-b435a4d97490@gmail.com>
	<CA+hUKGL+hiMRrAOqop1wmfpqTLg3GdyAJmO6KH6Dz3FjQvGN+w@mail.gmail.com>
	<143d3184-b575-49bd-8bc1-f37f45f010cc@gmail.com>
	<aS-F6LkeDBEly9nz@paquier.xyz>

Michael Paquier <michael@paquier.xyz> writes:
> It may be a good idea to split the patch into two parts, at least:
> - One for the bulk of the changes, for the straight-forward changes.
> Most of what you are suggesting are that for palloc_object and
> palloc_array which are dropped-in replacements.  Checking that these
> assemble the same before and after offers one extra layer of
> confidence.
> - Second one for the more dubious changes.

Yeah, I was thinking the same.  Some of those might perhaps be bugs
that we want to back-patch, so they need to be looked at in a
different way.

			regards, tom lane





view thread (29+ messages)  latest in thread

Message-ID: <534126.1764722446@sss.pgh.pa.us>
Permalink:  ../534126.1764722446@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/534126.1764722446@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, geidav.pg@gmail.com, thomas.munro@gmail.com, li.evan.chao@gmail.com
  Subject: Re: Consistently use palloc_object() and palloc_array()
  In-Reply-To: <534126.1764722446@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox