agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Antonin Houska <ah@cybertec.at>
To: Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Srinath Reddy Sadipiralla <srinath2133@gmail.com>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
Date: Thu, 26 Mar 2026 09:23:54 +0100
Message-ID: <5667.1774513434@localhost> (raw)
In-Reply-To: <CADzfLwURy8_BYyqrvr6rhTXsW3=5QMRLHuNati3CgY0nKRSwyw@mail.gmail.com>
References: <CAFC+b6qk3-DQTi43QMqvVLP+sudPV4vsLQm5iHfcCeObrNaVyA@mail.gmail.com>
<202603191855.fzsgsnyzfvpt@alvherre.pgsql>
<CADzfLwURy8_BYyqrvr6rhTXsW3=5QMRLHuNati3CgY0nKRSwyw@mail.gmail.com>
Mihail Nikalayeu <mihailnikalayeu@gmail.com> wrote:
> Hello, everyone!
>
> Some comments for v43:
Thanks!
> ------------------------------
>
> src/backend/catalog/index.c:766,1464-1469
>
> "bool progress = (flags & INDEX_CREATE_REPORT_PROGRESS) != 0;"
>
> AFAIU gin, hash and btree (at least) still just unconditionally write
> PROGRESS_CREATEIDX_* progress.
I think you're right, I'll check it.
> src/backend/catalog/toasting.c:334
>
> "INDEX_CREATE_IS_PRIMARY | INDEX_CREATE_REPORT_PROGRESS, 0,"
>
> Should we add the "progress" flag too here and move it from make_new_heap?
Good catch. I'd prefer removing this hunk from the patch because the index on
the TOAST relation is created while it's still empty.
(The other commens have already been addressed by Alvaro.)
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
view thread (416+ messages) latest in thread
Message-ID: <5667.1774513434@localhost>
Permalink: ../5667.1774513434@localhost/
Also on: postgresql.org/message-id/5667.1774513434@localhost
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ah@cybertec.at, mihailnikalayeu@gmail.com, alvherre@alvh.no-ip.org, srinath2133@gmail.com, boekewurm+postgres@gmail.com, pgsql-hackers@lists.postgresql.org, rob@xzilla.net
Subject: Re: Adding REPACK [concurrently]
In-Reply-To: <5667.1774513434@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox