pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: Jeff Davis <pgsql@j-davis.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_dump --with-* options
Date: Tue, 17 Jun 2025 10:02:48 +0900
Message-ID: <56f1a5ab-4852-4bec-883f-ea6b2fc437e5@oss.nttdata.com> (raw)
In-Reply-To: <CADkLM=fXSiX4GQ7F6__z+ofGpp0QwwytGP-GNeVQyMhc29bbwQ@mail.gmail.com>
References: <7cc52488-f876-4ad3-affd-6e4b0ef0cb09@eisentraut.org>
	<aEMLzPQtjRbj2R7X@nathan>
	<CA+TgmoactJEUHeXuxHLKNXHzm6-XrQFigPur-4nHTMFSiSRkiQ@mail.gmail.com>
	<aErpuM6RXSlK1FBW@nathan>
	<1854ffbf-f8eb-4bc3-b9f8-223bbf58c392@oss.nttdata.com>
	<271f899c54d112b353e009286af7c6cdb7c3d609.camel@j-davis.com>
	<aEyK6FxJqcv53s8b@nathan>
	<94f89b0a-5d83-4a67-9092-50ba3913441c@oss.nttdata.com>
	<CADkLM=fXSiX4GQ7F6__z+ofGpp0QwwytGP-GNeVQyMhc29bbwQ@mail.gmail.com>



On 2025/06/17 4:35, Corey Huinker wrote:
>     I noticed that --statistics (i.e., the current --with-statistics) causes
>     statistics to be dumped even when used with --data-only or --schema-only.
>     So, as far as I understand, here are the possible combinations of dump
>     targets and options:
> 
> 
> Those should also be mutually exclusive, and I'll write up a patch to add them to the checks.

--sequence-data behaves similarly, i.e., it still dumps sequence data
even when used with --schema-only. So I've been thinking of both
--statistics and --sequence-data as options that include additional data,
regardless of whether --*-only is specified.

It seems better to keep their behavior consistent to avoid confusing users.

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation






view thread (72+ messages)  latest in thread

Message-ID: <56f1a5ab-4852-4bec-883f-ea6b2fc437e5@oss.nttdata.com>
Permalink:  ../56f1a5ab-4852-4bec-883f-ea6b2fc437e5@oss.nttdata.com/
Also on:    postgresql.org/message-id/56f1a5ab-4852-4bec-883f-ea6b2fc437e5@oss.nttdata.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: masao.fujii@oss.nttdata.com, corey.huinker@gmail.com, nathandbossart@gmail.com, pgsql@j-davis.com, robertmhaas@gmail.com, peter@eisentraut.org
  Subject: Re: pg_dump --with-* options
  In-Reply-To: <56f1a5ab-4852-4bec-883f-ea6b2fc437e5@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox