From: Joshua D. Drake <jd@commandprompt.com>
To: Andres Freund <andres@anarazel.de>
Cc: Josh berkus <josh@agliodbs.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Reviewing freeze map code
Date: Fri, 6 May 2016 14:54:20 -0700
Message-ID: <572D128C.8040608@commandprompt.com> (raw)
In-Reply-To: <20160506214851.myiz46ui3b57abnb@alap3.anarazel.de>
References: <20160506205012.ipuhvctss2ozzs6m@alap3.anarazel.de>
<572D0471.3040009@commandprompt.com>
<20160506205824.ysst7mk3k26ztok2@alap3.anarazel.de>
<WM!3c465a785ef366521ed338bb93585bc99a43cc6db976bb0e71111a522ee7f39a31942de6526cb0bccd5f2b7d1678818f!@asav-3.01.com>
<572D062E.5030308@agliodbs.com>
<572D068F.3050608@commandprompt.com>
<20160506210806.f6pnk6ueirjqrlmu@alap3.anarazel.de>
<572D09D9.5080407@commandprompt.com>
<20160506212958.wwwc22hfesvj76af@alap3.anarazel.de>
<572D0F2D.7050207@commandprompt.com>
<20160506214851.myiz46ui3b57abnb@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 05/06/2016 02:48 PM, Andres Freund wrote:
> On 2016-05-06 14:39:57 -0700, Joshua D. Drake wrote:
>> Yes, this is true but with a proper testing framework, I don't need a 15
>> minute break. I need 1 hour to configure, the rest just "happens" and
>> reports back.
>
> That only works if somebody writes such tests.
Agreed.
> And in that case the
> tester having run will often suffice (until related changes are being
> made). I'm not arguing against introducing more tests into the codebase
> - I rather fervently for that. But that really isn't what's going to
> avoid issues like this feature (or multixact) causing problems, because
> those tests will just test what the author thought of.
>
Good point. I am not sure how to address the alternative though.
>
>>>> You want me (or people like me) to test more? Give us an easy way to
>>>> do it.
>>>
>>> Useful additional testing and easy just don't go well together. By the
>>> time I have made it easy I've done the testing that's needed.
>>
>> I don't know that I can agree with this. A proper harness allows you to
>> execute: go.sh and boom... 2, 4, even 8 hours later you get a report. I will
>> not argue that it isn't easy to implement but I know it can be done.
>
> The problem is that the contents of go.sh are the much more relevant
> part than the 8 hours.
True.
Please don't misunderstand, I am not saying this is "easy". I just hope
that it is something we work for.
Sincerely,
JD
--
Command Prompt, Inc. http://the.postgres.company/
+1-503-667-4564
PostgreSQL Centered full stack support, consulting and development.
Everyone appreciates your honesty, until you are honest with them.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: jd@commandprompt.com, andres@anarazel.de, josh@agliodbs.com, robertmhaas@gmail.com, sawada.mshk@gmail.com
Subject: Re: Reviewing freeze map code
In-Reply-To: <572D128C.8040608@commandprompt.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox