pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: David Fetter <david@fetter.org>
Cc: Ian Barwick <ian.barwick@2ndquadrant.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions
Date: Mon, 05 Aug 2019 12:43:24 -0400
Message-ID: <5739.1565023404@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmobXGnq_MqFnD4UnRVWYLrmjVadV_-OtxfxFkA_gpYDqzA@mail.gmail.com>
References: <31697.1564784856@sss.pgh.pa.us>
	<CAOuzzgqNyQM_z0biEEBVBK9WcaLmbCyWrd5xTdf-Oxb_9pntLA@mail.gmail.com>
	<32681.1564786027@sss.pgh.pa.us>
	<CAOuzzgpDj4kLNh7=bfEYv4zXrLgRziMogcXFSHzrhn74xjYXyQ@mail.gmail.com>
	<20190803004558.jfkbngi6g64eaqku@alap3.anarazel.de>
	<CAOuzzgpuH+uvT3Yvw5KC=keEqGifSc4eXQ6DB=yrowYyre2YvA@mail.gmail.com>
	<20190803010802.rs3cz2kjq4dl4olu@alap3.anarazel.de>
	<20190803124111.2aaddumd7url5wmq@development>
	<16320.1564851579@sss.pgh.pa.us>
	<d294b0d6-c00b-8a38-864f-4943a9471a6e@2ndquadrant.com>
	<20190805162203.GR31493@fetter.org>
	<4768.1565022305@sss.pgh.pa.us>
	<CA+TgmobXGnq_MqFnD4UnRVWYLrmjVadV_-OtxfxFkA_gpYDqzA@mail.gmail.com>

Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Aug 5, 2019 at 12:25 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Perhaps as a future improvement, but it's not happening for v12,
>> at least not unless you accept "use ALTER SYSTEM in a standalone
>> backend" as a usable answer.

> I'm not sure that would even work for the cases at issue ... because
> we're talking about setting up recovery parameters, and wouldn't the
> server run recovery before it got around to do anything with ALTER
> SYSTEM?

Yeah, good point.  There are a lot of other cases where you really
don't want system startup to happen, too.  On the other hand,
people have also opined that they want full error checking on
the inserted values, and that seems out of reach with less than
a full running system (mumble extensions mumble).

In the end, I think I don't buy Stephen's argument that there should
be a one-size-fits-all answer.  It seems entirely reasonable that
we'll have more than one way to do it, because the constraints are
different depending on what use-case you think about.

			regards, tom lane





view thread (117+ messages)  latest in thread

Message-ID: <5739.1565023404@sss.pgh.pa.us>
Permalink:  ../5739.1565023404@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/5739.1565023404@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, david@fetter.org, ian.barwick@2ndquadrant.com, tomas.vondra@2ndquadrant.com, andres@anarazel.de, sfrost@snowman.net, amit.kapila16@gmail.com
  Subject: Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions
  In-Reply-To: <5739.1565023404@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox