pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: plperl tests fail with latest Perl 5.36
Date: Wed, 01 Jun 2022 11:40:42 -0400
Message-ID: <578876.1654098042@sss.pgh.pa.us> (raw)
In-Reply-To: <87bkvcmn9i.fsf@wibble.ilmari.org>
References: <564579.1654093326@sss.pgh.pa.us>
	<87bkvcmn9i.fsf@wibble.ilmari.org>

=?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org> writes:
> Tom Lane <tgl@sss.pgh.pa.us> writes:
>> Apparently 5.36 rejiggers warning classifications in a way that breaks
>> one of our test cases.  Perhaps we should switch it to some other
>> warning-triggering condition.

> The simplest thing is to actually use sort in void context,
> i.e. removing the `my $x = ` part from the test, see the attached.

Looks reasonable to me, but I'm hardly a Perl monk.  Anybody have
a different opinion?

			regards, tom lane





view thread (5+ messages)  latest in thread

Message-ID: <578876.1654098042@sss.pgh.pa.us>
Permalink:  ../578876.1654098042@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/578876.1654098042@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, ilmari@ilmari.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: plperl tests fail with latest Perl 5.36
  In-Reply-To: <578876.1654098042@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox