From: Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp>
To: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Minor code improvement to postgresGetForeignJoinPaths
Date: Tue, 25 Oct 2016 14:59:15 +0900
Message-ID: <580EF4B3.9090107@lab.ntt.co.jp> (raw)
In-Reply-To: <CAFjFpRftW1eXp3+y78pbF8jxAgE+JATJc3ATJzsJMN_fanVy1w@mail.gmail.com>
References: <580D716B.1050600@lab.ntt.co.jp>
<CAFjFpRftW1eXp3+y78pbF8jxAgE+JATJc3ATJzsJMN_fanVy1w@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Hi Ashutosh,
> You are right. Every call except that one is using NIL, so better to
> fix it. The pattern was repeated in the recent aggregate pushdown
> support. Here's patch to fix create_foreignscan_path() call in
> add_foreign_grouping_paths() as well.
Thanks for the review!
Tatsuro Yamada
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: yamada.tatsuro@lab.ntt.co.jp, ashutosh.bapat@enterprisedb.com
Subject: Re: Minor code improvement to postgresGetForeignJoinPaths
In-Reply-To: <580EF4B3.9090107@lab.ntt.co.jp>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox