From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Improving isolationtester's data output
Date: Tue, 15 Jun 2021 19:26:25 -0400
Message-ID: <583674.1623799585@sss.pgh.pa.us> (raw)
In-Reply-To: <202106152320.xfiprkh4sp5c@alvherre.pgsql>
References: <202106152320.xfiprkh4sp5c@alvherre.pgsql>
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2021-Jun-15, Tom Lane wrote:
>> If we wanted to buy into that, I'd think about discarding this
>> ad-hoc code altogether in favor of using one of libpq's fe-print.c
>> routines. But I'm not really sure that the small legibility gains
>> that would result are worth massive changes in the output files.
> Shrug -- it's a one time change. It wouldn't bother me, for one.
Going forward it wouldn't be a problem, but back-patching isolation
test cases might find it annoying. On the other hand, my nearby
patch to improve isolation test stability is already going to create
issues of that sort. (Unless, dare I say it, we back-patch that.)
I do find it a bit attractive to create some regression-testing
coverage of fe-print.c. We are never going to remove that code,
AFAICS, so getting some benefit from it would be nice.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org
Subject: Re: Improving isolationtester's data output
In-Reply-To: <583674.1623799585@sss.pgh.pa.us>
References: <202106152320.xfiprkh4sp5c@alvherre.pgsql> <583674.1623799585@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox