pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: ikedarintarof <ikedarintarof@oss.nttdata.com>
Cc: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: doc: modify the comment in function libpqrcv_check_conninfo()
Date: Tue, 9 Jul 2024 21:33:33 +0900
Message-ID: <5899b3bf-8a34-46bb-ae75-6847828bb942@oss.nttdata.com> (raw)
In-Reply-To: <7d845121f0ea99e68b4403b9cd6f86ac@oss.nttdata.com>
References: <6a1ca81b27fec4da0ccdfaaaec787982@oss.nttdata.com>
	<CAGECzQRjJkCQ9AUQA_7kJw8c4iUwVAXPfD_VQu+-DVcd-LCT8A@mail.gmail.com>
	<9c15a4b74d09348d03b02934fc429c94@oss.nttdata.com>
	<CAGECzQQ+bpYVuF6GpVdc9vzHOObs5HJLmj5YohOb2d-ctmCffg@mail.gmail.com>
	<c380192faada009af9aa5bfcd06e140d@oss.nttdata.com>
	<CAGECzQRPygEJr3Ed2p7QsUsBkecUa0mpiE3zMOEh5_NtvAfgRw@mail.gmail.com>
	<202ec279-c307-48b9-9920-730fb1221d27@oss.nttdata.com>
	<d5f5fb21f27c17c400a4dbe386d008a8@oss.nttdata.com>
	<2faf37e9-3941-43b5-93e8-f54965b250df@oss.nttdata.com>
	<7d845121f0ea99e68b4403b9cd6f86ac@oss.nttdata.com>



On 2024/07/09 15:56, ikedarintarof wrote:
>> - * Validate connection info string, and determine whether it might cause
>> - * local filesystem access to be attempted.
>> + * The function
>> + * 1. validates connection info string and
>> + * 2. checks a password is provided if must_use_password is true.
>>
>> IMO, "Validate connection info string" is sufficient. The mention of
>> must_use_password is redundant since it's explained in the latter part of
>> the comment.
> 
> That is reasonable for me. I've removed the second one.
> The modified patch is attached.

Thanks for updating the patch! Pushed.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION





view thread (11+ messages)

Message-ID: <5899b3bf-8a34-46bb-ae75-6847828bb942@oss.nttdata.com>
Permalink:  ../5899b3bf-8a34-46bb-ae75-6847828bb942@oss.nttdata.com/
Also on:    postgresql.org/message-id/5899b3bf-8a34-46bb-ae75-6847828bb942@oss.nttdata.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: masao.fujii@oss.nttdata.com, ikedarintarof@oss.nttdata.com, postgres@jeltef.nl, robertmhaas@gmail.com
  Subject: Re: doc: modify the comment in function libpqrcv_check_conninfo()
  In-Reply-To: <5899b3bf-8a34-46bb-ae75-6847828bb942@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox