From: ikedarintarof <ikedarintarof@oss.nttdata.com>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: pgsql-hackers@postgresql.org
Subject: Re: doc: modify the comment in function libpqrcv_check_conninfo()
Date: Thu, 27 Jun 2024 19:27:33 +0900
Message-ID: <c380192faada009af9aa5bfcd06e140d@oss.nttdata.com> (raw)
In-Reply-To: <CAGECzQQ+bpYVuF6GpVdc9vzHOObs5HJLmj5YohOb2d-ctmCffg@mail.gmail.com>
References: <6a1ca81b27fec4da0ccdfaaaec787982@oss.nttdata.com>
<CAGECzQRjJkCQ9AUQA_7kJw8c4iUwVAXPfD_VQu+-DVcd-LCT8A@mail.gmail.com>
<9c15a4b74d09348d03b02934fc429c94@oss.nttdata.com>
<CAGECzQQ+bpYVuF6GpVdc9vzHOObs5HJLmj5YohOb2d-ctmCffg@mail.gmail.com>
Thanks for your suggestion. I used ChatGPT to choose the wording, but
it's still difficult for me.
The new patch includes your suggestion.
On 2024-06-27 17:18, Jelte Fennema-Nio wrote:
> On Thu, 27 Jun 2024 at 09:09, ikedarintarof
> <ikedarintarof@oss.nttdata.com> wrote:
>>
>> Thank you for your comment!
>>
>> I've added the must_use_password argument. A new patch is attached.
>
> s/whther/whether
>
> nit: "it will do nothing" sounds a bit strange to me (but I'm not
> native english). Something like this reads more natural to me:
>
> an error. If must_use_password is true, the function raises an error
> if no password is provided in the connection string. In any other case
> it successfully completes.
Attachments:0001-modify-the-commnet-in-libpqrcv_check_conninfo.patch (text/x-diff, 1.2K) download
From c01cadcb955d79ff525992985bd59736c6731abe Mon Sep 17 00:00:00 2001
From: Rintaro Ikeda <51394766+rinikeda@users.noreply.github.com>
Date: Thu, 27 Jun 2024 16:04:08 +0900
Subject: [PATCH] modify the commnet in libpqrcv_check_conninfo()
---
src/backend/replication/libpqwalreceiver/libpqwalreceiver.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.cindex 02f12f2921..4f7b69a73d 100644--- a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c+++ b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c@@ -309,8 +309,9 @@ bad_connection:
* local filesystem access to be attempted.
*
* If the connection string can't be parsed, this function will raise
- * an error and will not return. If it can, it will return true if this- * connection string specifies a password and false otherwise.+ * an error. If must_use_password is true, the function raises an error+ * if no password is provided in the connection string. In any other case+ * it successfully completes.
*/
static void
libpqrcv_check_conninfo(const char *conninfo, bool must_use_password)
--
2.39.3 (Apple Git-146)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ikedarintarof@oss.nttdata.com, postgres@jeltef.nl
Subject: Re: doc: modify the comment in function libpqrcv_check_conninfo()
In-Reply-To: <c380192faada009af9aa5bfcd06e140d@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox