pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Chapman Flack <chap@anastigmatix.net>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
To: Stephen Frost <sfrost@snowman.net>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] AdvanceXLInsertBuffer vs. WAL segment compressibility
Date: Thu, 29 Mar 2018 21:18:59 -0400
Message-ID: <5ABD9083.5050908@anastigmatix.net> (raw)
In-Reply-To: <8c00b26a-d6da-5764-e67e-9c4d8128081a@2ndquadrant.com>
References: <CAB7nPqQr1D3gjx8CmHYQREidG2eeGHzx2yQ97B3t2L99GE=+kQ@mail.gmail.com>
	<5A92F0C0.7070706@anastigmatix.net>
	<C0523BD1-485D-48B5-982E-8D63E2D001B7@yesql.se>
	<5AADB130.2020206@anastigmatix.net>
	<4597.1521338981@sss.pgh.pa.us>
	<46FFB930-B0F3-400A-85ED-D9948C97FADF@yesql.se>
	<5AAEE00E.9050503@anastigmatix.net>
	<21C25ED8-4ED8-4AD4-B551-3E3987ECB18F@yesql.se>
	<5AAEFF11.3070903@anastigmatix.net>
	<20180326032731.GM24540@tamriel.snowman.net>
	<20180326054354.GB2759@paquier.xyz>
	<5ABAC668.5080203@anastigmatix.net>
	<8c00b26a-d6da-5764-e67e-9c4d8128081a@2ndquadrant.com>

On 03/27/18 20:09, Tomas Vondra wrote:
> Not sure what's up with gitweb, but git finds it without any issue:
> 
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=2dd9322ba6eea76800b38bfea0599fbc45945...

Thanks, that worked.

On 03/27/18 22:10, Michael Paquier wrote:
> Here you go for one example:
> https://sourceforge.net/projects/pglesslog/

So far, I have been able to study the commit pertaining to
XLP_BKP_REMOVABLE. For again some odd reason, I am striking out on
finding pglesslog code to study. Using the clone URL offered by sourceforge:

$ git clone https://git.code.sf.net/p/pglesslog/code pglesslog-code
Cloning into 'pglesslog-code'...
warning: You appear to have cloned an empty repository.
Checking connectivity... done.

and there's a Files tab, but it tells me This project has no files.

I can find 1.4.2 beta on pgFoundry, but that predates the BKP_REMOVABLE
commit.


In any case, from my study of the commit, it is hard for me to see an issue.
The code comment says: "mark the header to indicate that WAL records
beginning in this page have removable backup blocks."

In the only case where this patch will zero a header--in the unused space
following the switch record in a segment--there are no "WAL records
beginning in this page". There will not be another WAL record of any kind
until the next valid page (with valid xlp_magic xlp_tli xlp_pageaddr),
which will be at the start of the next segment, and that page will have
XLP_BKP_REMOVABLE if it ought to, and that will tell the reader what it
needs to know.

Am I overlooking something?

-Chap




view thread (49+ messages)  latest in thread

Message-ID: <5ABD9083.5050908@anastigmatix.net>
Permalink:  ../5ABD9083.5050908@anastigmatix.net/
Also on:    postgresql.org/message-id/5ABD9083.5050908@anastigmatix.net

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: chap@anastigmatix.net, tomas.vondra@2ndquadrant.com, michael@paquier.xyz, sfrost@snowman.net, daniel@yesql.se, tgl@sss.pgh.pa.us, michael.paquier@gmail.com, hlinnaka@iki.fi, robertmhaas@gmail.com, bruce@momjian.us
  Subject: Re: [HACKERS] AdvanceXLInsertBuffer vs. WAL segment compressibility
  In-Reply-To: <5ABD9083.5050908@anastigmatix.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox