pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Chapman Flack <chap@anastigmatix.net>
To: Michael Paquier <michael@paquier.xyz>
To: Stephen Frost <sfrost@snowman.net>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] AdvanceXLInsertBuffer vs. WAL segment compressibility
Date: Wed, 28 Mar 2018 02:09:10 +0200
Message-ID: <8c00b26a-d6da-5764-e67e-9c4d8128081a@2ndquadrant.com> (raw)
In-Reply-To: <5ABAC668.5080203@anastigmatix.net>
References: <CAB7nPqQr1D3gjx8CmHYQREidG2eeGHzx2yQ97B3t2L99GE=+kQ@mail.gmail.com>
	<5A92F0C0.7070706@anastigmatix.net>
	<C0523BD1-485D-48B5-982E-8D63E2D001B7@yesql.se>
	<5AADB130.2020206@anastigmatix.net>
	<4597.1521338981@sss.pgh.pa.us>
	<46FFB930-B0F3-400A-85ED-D9948C97FADF@yesql.se>
	<5AAEE00E.9050503@anastigmatix.net>
	<21C25ED8-4ED8-4AD4-B551-3E3987ECB18F@yesql.se>
	<5AAEFF11.3070903@anastigmatix.net>
	<20180326032731.GM24540@tamriel.snowman.net>
	<20180326054354.GB2759@paquier.xyz>
	<5ABAC668.5080203@anastigmatix.net>



On 03/28/2018 12:32 AM, Chapman Flack wrote:
> On 03/26/18 01:43, Michael Paquier wrote:
> 
>> Have a look at BKP_REMOVABLE then.  This was moved to page headers in
>> 2dd9322, still it seems to me that the small benefits outlined on this
>> thread don't justify breaking tools relying on this flag set, especially
>> if there is no replacement for it.
> 
> Is 2dd9322 a commit? I'm having difficulty finding it:
> 
> https://git.postgresql.org/gitweb/?p=postgresql.git&a=search&h=HEAD&st=commit&s=2dd9...
> 
> Am I searching wrong?
> 

Not sure what's up with gitweb, but git finds it without any issue:

https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=2dd9322ba6eea76800b38bfea0599fbc45945...

> I probably won't have more time to look at this tonight, but could
> I ask in advance for examples of tools that would need this bit when
> encountering unwritten pages at the end of a segment?
> 
> I don't mean that as snark; it's just nonobvious to me and I might need
> a little nudge where to look.
> 
> -Chap
> 

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




view thread (49+ messages)  latest in thread

Message-ID: <8c00b26a-d6da-5764-e67e-9c4d8128081a@2ndquadrant.com>
Permalink:  ../8c00b26a-d6da-5764-e67e-9c4d8128081a@2ndquadrant.com/
Also on:    postgresql.org/message-id/8c00b26a-d6da-5764-e67e-9c4d8128081a@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tomas.vondra@2ndquadrant.com, chap@anastigmatix.net, michael@paquier.xyz, sfrost@snowman.net, daniel@yesql.se, tgl@sss.pgh.pa.us, michael.paquier@gmail.com, hlinnaka@iki.fi, robertmhaas@gmail.com, bruce@momjian.us
  Subject: Re: [HACKERS] AdvanceXLInsertBuffer vs. WAL segment compressibility
  In-Reply-To: <8c00b26a-d6da-5764-e67e-9c4d8128081a@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox