From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>
Subject: Re: Should contrib modules install .h files?
Date: Mon, 02 Jul 2018 16:46:04 -0400
Message-ID: <64174.1530564364@sss.pgh.pa.us> (raw)
In-Reply-To: <878t6to8j9.fsf@news-spur.riddles.org.uk>
References: <87y3euomjh.fsf@news-spur.riddles.org.uk>
<ee05ea4c-3d5b-0ec6-8daa-3ec66f021076@2ndquadrant.com>
<87tvpinfr4.fsf@news-spur.riddles.org.uk>
<63444.1530537990@sss.pgh.pa.us>
<87lgatohzp.fsf@news-spur.riddles.org.uk>
<63655.1530540982@sss.pgh.pa.us>
<87h8lhoevw.fsf@news-spur.riddles.org.uk>
<63819.1530544945@sss.pgh.pa.us>
<878t6to8j9.fsf@news-spur.riddles.org.uk>
Andrew Gierth <andrew@tao11.riddles.org.uk> writes:
> Two questions arise:
> 1) include/server has a lot of files and subdirs, so using
> include/server/$(MODULE)/ looks likely to be error-prone. So it
> should be something like include/server/contrib/$(MODULE)/ or
> include/server/extension/$(MODULE)/. Which one, or should it use
> $(MODULEDIR) to choose between the two the way that DATA and DOCS do?
> Or something else?
Might as well follow the MODULEDIR precedent (though I'm not wedded
to that if somebody has an argument for something else).
> 2) Specifying HEADERS_blah for some name "blah" that's not listed in
> MODULES or MODULE_big should do what:
> a) install into blah/ anyway
> b) be ignored with a warning
> c) be silently ignored
> d) be an error
I'd definitely vote for "error". Likewise if any .h file listed in
the macro doesn't exist.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andrew@tao11.riddles.org.uk, peter.eisentraut@2ndquadrant.com, andres@anarazel.de
Subject: Re: Should contrib modules install .h files?
In-Reply-To: <64174.1530564364@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox