From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: predefined role(s) for VACUUM and ANALYZE
Date: Fri, 30 Sep 2022 16:15:24 -0400
Message-ID: <678838.1664568924@sss.pgh.pa.us> (raw)
In-Reply-To: <20220930192350.GA171832@nathanxps13>
References: <20220920035147.GA114383@nathanxps13>
<YylTkIwvWuYJkMnT@paquier.xyz>
<20220920180533.GA205278@nathanxps13>
<20220920233117.GA378596@nathanxps13>
<20220920235010.GB378596@nathanxps13>
<Yyppg/c4SB7s1IAv@paquier.xyz>
<20220921043126.GA382738@nathanxps13>
<20220928185034.GA1397229@nathanxps13>
<CAOuzzgpQtdqj2BfwheD9+fjUnVSo1cmdrQmwcr-qbvKjC5cfyg@mail.gmail.com>
<20220928201222.GA1400058@nathanxps13>
<20220930192350.GA171832@nathanxps13>
Nathan Bossart <nathandbossart@gmail.com> writes:
> Are there any remaining concerns about this approach? I'm happy to do any
> testing that folks deem necessary, or anything else really that might help
> move this patch set forward. If we don't want to extend AclMode right
> away, we could also keep it in our back pocket for the next time someone
> (which may very well be me) wants to add privileges. That is, 0001 is not
> fundamentally a prerequisite for 0002-0004, but I recognize that freeing up
> some extra bits would be the most courteous.
In view of the recent mess around bigint relfilenodes, it seems to me
that we shouldn't move forward with widening AclMode unless somebody
runs down which structs will get wider (or more aligned) and how much
that'll cost us. Maybe it's not a problem, but it could do with an
explicit look at the point.
I do agree with the position that these features are not where to
spend our last remaining privilege bits.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, nathandbossart@gmail.com, sfrost@snowman.net, bharath.rupireddyforpostgres@gmail.com, david.g.johnston@gmail.com, horikyota.ntt@gmail.com, michael@paquier.xyz, robertmhaas@gmail.com
Subject: Re: predefined role(s) for VACUUM and ANALYZE
In-Reply-To: <678838.1664568924@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox