pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: predefined role(s) for VACUUM and ANALYZE
Date: Wed, 28 Sep 2022 11:50:34 -0700
Message-ID: <20220928185034.GA1397229@nathanxps13> (raw)
In-Reply-To: <20220921043126.GA382738@nathanxps13>
References: <20220907221103.GA2095022@nathanxps13>
	<CAOuzzgr60X+pnVphekO=WnAwGo9pTbo9ZG_GK4nFaR=Dxqd1hg@mail.gmail.com>
	<CA+TgmoaQExEDdRmQsFCd955dxCypDBeA_FOrUKCLNWAdQ69zxg@mail.gmail.com>
	<20220920035147.GA114383@nathanxps13>
	<YylTkIwvWuYJkMnT@paquier.xyz>
	<20220920180533.GA205278@nathanxps13>
	<20220920233117.GA378596@nathanxps13>
	<20220920235010.GB378596@nathanxps13>
	<Yyppg/c4SB7s1IAv@paquier.xyz>
	<20220921043126.GA382738@nathanxps13>

On Tue, Sep 20, 2022 at 09:31:26PM -0700, Nathan Bossart wrote:
> I bet a more pressing concern is the calls to aclmask() since checking
> privileges is probably done more frequently than updating them.  That
> appears to use a linear search, too, so maybe sorting the aclitem arrays is
> actually worth exploring.  I still doubt there will be much noticeable
> impact from expanding AclMode outside of the most extreme cases.

I've been testing aclmask() with long aclitem arrays (2,000 entries is
close to the limit for pg_class entries), and I haven't found any
significant impact from bumping AclMode to 64 bits.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (63+ messages)  latest in thread

Message-ID: <20220928185034.GA1397229@nathanxps13>
Permalink:  ../20220928185034.GA1397229@nathanxps13/
Also on:    postgresql.org/message-id/20220928185034.GA1397229@nathanxps13

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, michael@paquier.xyz, robertmhaas@gmail.com, sfrost@snowman.net, bharath.rupireddyforpostgres@gmail.com, david.g.johnston@gmail.com, horikyota.ntt@gmail.com
  Subject: Re: predefined role(s) for VACUUM and ANALYZE
  In-Reply-To: <20220928185034.GA1397229@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox