pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org, Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Alexander Kuzmenkov <a.kuzmenkov@postgrespro.ru>
Subject: Re: Performance improvements for src/port/snprintf.c
Date: Wed, 03 Oct 2018 14:48:59 -0400
Message-ID: <6797.1538592539@sss.pgh.pa.us> (raw)
In-Reply-To: <20181003183552.xaams6fau3i7oybj@alap3.anarazel.de>
References: <20181003161454.ozeioucsimjg5g6m@alap3.anarazel.de>
	<27041.1538583733@sss.pgh.pa.us>
	<20181003163717.oycshpp2hnctvtfj@alap3.anarazel.de>
	<28321.1538585692@sss.pgh.pa.us>
	<20181003170043.thdyezozi343dkuc@alap3.anarazel.de>
	<2132.1538587869@sss.pgh.pa.us>
	<20181003173639.tncawup2nnkp7vbv@alap3.anarazel.de>
	<2435.1538588403@sss.pgh.pa.us>
	<20181003174513.wxjxfj7eepytnlqa@alap3.anarazel.de>
	<3316.1538589695@sss.pgh.pa.us>
	<20181003183552.xaams6fau3i7oybj@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2018-10-03 14:01:35 -0400, Tom Lane wrote:
>> BTW, so far as I can tell on F28, strfromd isn't exposed without
>> "-D__STDC_WANT_IEC_60559_BFP_EXT__", which seems fairly scary;
>> what else does that affect?

> So I don't think anything's needed to enable that in pg, given that we
> define _GNU_SOURCE

Ah, OK.  I thought my test case had _GNU_SOURCE defined already,
but it didn't.  You might want to do something like what I stuck
in for strchrnul, though:

/*
 * glibc's <string.h> declares strchrnul only if _GNU_SOURCE is defined.
 * While we typically use that on glibc platforms, configure will set
 * HAVE_STRCHRNUL whether it's used or not.  Fill in the missing declaration
 * so that this file will compile cleanly with or without _GNU_SOURCE.
 */
#ifndef _GNU_SOURCE
extern char *strchrnul(const char *s, int c);
#endif


			regards, tom lane




view thread (65+ messages)  latest in thread

Message-ID: <6797.1538592539@sss.pgh.pa.us>
Permalink:  ../6797.1538592539@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/6797.1538592539@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, thomas.munro@enterprisedb.com, andrew@tao11.riddles.org.uk, a.kuzmenkov@postgrespro.ru
  Subject: Re: Performance improvements for src/port/snprintf.c
  In-Reply-To: <6797.1538592539@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox