From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Subject: Re: Internal error codes triggered by regression tests and user queries, take 2
Date: Wed, 26 Aug 2026 10:26:58 -0400
Message-ID: <697477.1787754418@sss.pgh.pa.us> (raw)
In-Reply-To: <94ac928b-8370-4db5-ada5-579a9ebc089d@gmail.com>
References: <94ac928b-8370-4db5-ada5-579a9ebc089d@gmail.com>
Alexander Lakhin <exclusion@gmail.com> writes:
> Please take a look at the follow-up to [0]. I've prepared a patch to
> assign error codes for errors reached by the following queries:
I'm not on board with these proposed changes to [try_]relation_open.
They're basically band-aids rather than fixes of the root problems.
That is, if someone passes OID 0 to relation_open, that IS an internal
bug; labeling it otherwise is a lie and does nothing to fix the real
problem at the caller level.
A lot of these other proposed changes have the same whiff of blaming
the messenger rather than looking for the root cause.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, exclusion@gmail.com, michael@paquier.xyz, pryzby@telsasoft.com
Subject: Re: Internal error codes triggered by regression tests and user queries, take 2
In-Reply-To: <697477.1787754418@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox