From: Michael Paquier <michael@paquier.xyz>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Subject: Re: Internal error codes triggered by regression tests and user queries, take 2
Date: Tue, 22 Sep 2026 19:49:03 +0900
Message-ID: <arJdH4WF14EXwWmt@paquier.xyz> (raw)
In-Reply-To: <7a9b3652-134c-4565-82ad-839035a3a382@gmail.com>
References: <94ac928b-8370-4db5-ada5-579a9ebc089d@gmail.com>
<697477.1787754418@sss.pgh.pa.us>
<mosliefjrclrikqpsasjy5ibzowba6vwk4ygimouikiht2i5pb@5g562jqflxsz>
<73eb724a-c1a3-456c-be12-0375d4556b67@gmail.com>
<apUcBVyazHEW5pcg@paquier.xyz>
<91a1b0ab-2c6c-4471-b7a4-ee8ee8aed64e@gmail.com>
<126103.1788721678@sss.pgh.pa.us>
<8343126e-11e5-48df-9f96-ea03a2b7d5ba@gmail.com>
<7a9b3652-134c-4565-82ad-839035a3a382@gmail.com>
On Sat, Sep 12, 2026 at 02:00:00PM +0300, Alexander Lakhin wrote:
> Please look at the attached v3-Define-...patch, where I think I addressed
> all of your comments.
The ACL bits were slightly puzzling because it's the first time I see
this pattern in the code (following Tom's comment upthread also in
tsvector), and I indeed get much better error messages:
=# SELECT acldefault(E'\x80'::"char", 0);
ERROR: 22021: invalid byte sequence for encoding "UTF8": 0x80
=# SELECT acldefault(chr(1)::"char", 10);
ERROR: 22023: unrecognized object type abbreviation: "\001"
The second query just showed nothing originally.
For the typmods, %d is a better choice to me as the input is an
integer.
As a whole, that looks OK, so applied on HEAD. I did not look at
0002.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../arJdH4WF14EXwWmt@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, exclusion@gmail.com, tgl@sss.pgh.pa.us, andres@anarazel.de, pryzby@telsasoft.com
Subject: Re: Internal error codes triggered by regression tests and user queries, take 2
In-Reply-To: <arJdH4WF14EXwWmt@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox